Menu ▾ ▴

#27 [PATCH] client socket is not closed

closed
nobody
None
5
2009-05-22
2009-05-20
Stefan Becker
No

When the client code closes the connection to the server it doesn't close the socket. Therefore VNC clients that don't exit immediately after closing the connection to the server are leaking file handles. F.ex. VNC connections via SSH tunnel keep the ssh connection open, because the socket isn't closed.

KDE's krdc is one example for a client that suffers from this problem. See my original bug report here

<https://bugs.kde.org/show_bug.cgi?id=184840>

The attached patch fixes the problem.

Discussion

  • Stefan Becker

    Stefan Becker - 2009-05-21

    Add close() to rfbClientCleanup()

     
    LibVNCServer-0.9.1-close-server-socket.patch

  • Stefan Becker

    Stefan Becker - 2009-05-21

    Slightly improved patch: check for non-negative file descriptor, not non-zero one.

     

  • Johannes Schindelin

    Johannes Schindelin - 2009-05-22

    Thanks, I applied your patch (with an indentation fix)

     

  • Johannes Schindelin

    Johannes Schindelin - 2009-05-22
    • status: open --> closed