Tracker: Patches

5 README and dump.c fixes - ID: 3551919
Last Update: Comment added ( michal-n )

Started hunting for files, added a couple more pointers to the README, also fixed the buffer[] to NOT point to 401 or 201 (C starts at zero)

Jose Da Silva ( josedasilva ) - 2012-07-30 02:15:34 PDT

5

Closed

Accepted

Nobody/Anonymous

None

None

Public


Comments ( 3 )

Date: 2012-08-05 06:45:46 PDT
Sender: michal-nProject Admin

Thanks, applied.

Date: 2012-08-04 14:38:46 PDT
Sender: josedasilvaAccepting Donations

I've gone and searched for cppcheck, found it, compiled it now.
seems to be a useful program to catch stuff missed by gcc during compile.

Those errors are fixed now, was optimizing routines to not bother
initializing stuff if they branched into the else statement, but those two
particular if statements made use of the j for the array. I've uploaded a
patch.

Date: 2012-08-04 04:54:15 PDT
Sender: michal-nProject Admin

Thanks, applied.
But I had chance to run newer version of cppcheck and got:

[fontforge/Unicode/dump.c:542]: (error) Uninitialized variable: j
[fontforge/Unicode/dump.c:544]: (error) Uninitialized variable: j
[fontforge/Unicode/dump.c:650]: (error) Uninitialized variable: j
[fontforge/Unicode/dump.c:652]: (error) Uninitialized variable: j

Attached Files ( 2 )

Filename Description Download
dump_README.diff file pointer updates, removed buffer[] errors introduced earlier in previous dump.c.diff Download
dump_j.diff correction for 4 errors described 2012aug4 Download

Changes ( 6 )

Field Old Value Date By
status_id Open 2012-08-05 06:45:46 PDT michal-n
resolution_id None 2012-08-05 06:45:46 PDT michal-n
allow_comments 1 2012-08-05 06:45:46 PDT michal-n
close_date - 2012-08-05 06:45:46 PDT michal-n
File Added 450558: dump_j.diff 2012-08-04 14:35:47 PDT josedasilva
File Added 450124: dump_README.diff 2012-07-30 02:15:40 PDT josedasilva