Tracker: Patches

5 makeutype.c update with error checks, also include updates f - ID: 3551379
Last Update: Settings changed ( michal-n )

More fixes. lots of error checks. some extra commenting. Cleanup of own memory when done before exiting.

Several files are updated and should include extra Unicode characters when the program is run using the latest unicode.org files.

Error-checking now catches long lines and notified that Namelist contains lines longer than 300 chars in length, therefore modified program to accept the longer lines for NameList.txt, but still complain about long lines for the other files since I don't know (yet) if long lines may affect some files higher up the chain.

Note, several new unicode characters have been added with this update.

Jose Da Silva ( josedasilva ) - 2012-07-29 08:32:16 PDT

5

Closed

Accepted

Nobody/Anonymous

None

None

Public


Comments ( 4 )

Date: 2012-08-06 09:59:48 PDT
Sender: michal-nProject Admin

Partially applied.
makeutype_commenting2.diff is unapplicable.

Date: 2012-08-04 04:55:36 PDT
Sender: michal-nProject Admin

I'll wait for ticket 3551919.

Date: 2012-07-31 01:46:54 PDT
Sender: josedasilvaAccepting Donations

Hi Michal,
I saw the latest git update - it is closer.
Can you apply "makeutype.diff"
Then wget the 4 files needed to from unicode.org and run the program.
It should create 4 updated files. utype.h will need to be moved to ../inc/
The updated files will look much like what you see changed in
"updated_files.diff" which is visible for anyone wanting to see what
changed.
When you do the next update, you can apply "makeutype_commenting2.diff"
which makes the code look nicer, but due to the edits "\n " changed to "\n"
makes the diff update very difficult to see what actually got changed - if
you don't like that, then leave the lines the same where you see "\n "
<--space follows the newline. The updated changes will be large, but not as
large as if it was "\n" applied (in patch makeutype_commenting2.diff).

Date: 2012-07-29 08:58:07 PDT
Sender: josedasilvaAccepting Donations

Please hold-off on running and updating makeutype.c (with the additional
commenting) with this "commented" version until you are satisfied with the
updates done on utype.c because this update generates a lot of "noise" on
utype.c which makes it hard to see the differences.

Attached Files ( 5 )

Filename Description Download
makeutype.diff working program to create fontforge c and h files Download
makeutype_file_update.diff files updated based on latest unicode.org data Download
updated_files.diff updates (before comments added) Download
TestLine.txt A bunch of very long lines in a text file Download
makeutype_commenting2.diff more commenting added leave this as last change due to large diff file created which makes it near imposible to see changes made Download

Changes ( 12 )

Field Old Value Date By
close_date 2012-08-04 04:55 2012-08-22 03:34:21 PDT michal-n
allow_comments 1 2012-08-22 03:34:21 PDT michal-n
resolution_id Later 2012-08-22 03:34:21 PDT michal-n
status_id Pending 2012-08-22 03:34:21 PDT michal-n
resolution_id None 2012-08-06 09:59:48 PDT michal-n
close_date - 2012-08-04 04:55:36 PDT michal-n
status_id Open 2012-08-04 04:55:36 PDT michal-n
File Added 450118: makeutype_commenting2.diff 2012-07-30 00:06:06 PDT josedasilva
File Added 450113: TestLine.txt 2012-07-29 20:31:09 PDT josedasilva
File Added 450068: updated_files.diff 2012-07-29 09:01:28 PDT josedasilva
File Added 450067: makeutype_file_update.diff 2012-07-29 08:38:33 PDT josedasilva
File Added 450066: makeutype.diff 2012-07-29 08:32:18 PDT josedasilva