Tracker: Patches

5 makeutype.c update - ID: 3548658
Last Update: Comment added ( josedasilva )

Fixed some possible buffer[] overruns.


Jose Da Silva ( josedasilva ) - 2012-07-25 21:45:53 PDT

5

Closed

Accepted

Nobody/Anonymous

None

None

Public


Comments ( 3 )

Date: 2012-07-29 20:34:42 PDT
Sender: josedasilvaAccepting Donations

Thanks Michal for looking-out for these things.
Since you've already included/accepted this patch, I started a new patch at
#3551379

In future, do you want these fixes submitted back to the same patch, or to
start a new patch?

Thanks,
Joe


Date: 2012-07-27 09:13:32 PDT
Sender: michal-nProject Admin

I had to adjust the patches slightly, as cppcheck complained:

[makeutype.c:202]: (error) Array 'buffer[301]' index 301 out of bounds
[makeutype.c:202]: (error) Array 'buf2[301]' index 301 out of bounds
[makeutype.c:475]: (error) Array 'buffer[301]' index 301 out of bounds
[makeutype.c:475]: (error) Array 'buf2[301]' index 301 out of bounds
[makeutype.c:512]: (error) Array 'name[301]' index 301 out of bounds


Date: 2012-07-26 10:35:03 PDT
Sender: michal-nProject Admin

Thanks, applied.


Attached Files ( 2 )

Filename Description Download
makeutype.diff makeutype.c update and fixes Download
makeutype2.diff makeutype.c additional update (forgot to include this) Download

Changes ( 7 )

Field Old Value Date By
allow_comments 0 2012-07-27 09:13:32 PDT michal-n
status_id Open 2012-07-26 10:35:05 PDT michal-n
resolution_id None 2012-07-26 10:35:05 PDT michal-n
allow_comments 1 2012-07-26 10:35:05 PDT michal-n
close_date - 2012-07-26 10:35:05 PDT michal-n
File Added 449830: makeutype2.diff 2012-07-25 22:18:16 PDT josedasilva
File Added 449829: makeutype.diff 2012-07-25 21:45:54 PDT josedasilva