jEdit

Tracker: Merge Requests

5 MiscUtilities.openInDesktop() in jEdit 5.0 - ID: 3534174

Last Update: Comment added ( jarekczek )

Details:

Originally, I was just going to move the code out of the browser.actions.xml file and into MiscUtilities
but during testing, I found and fixed a couple of bugs in related to files with spaces in the names.

So revision # 21791 moves the code into MiscUtilities (which is a new API) and also fixes some of the code
that was there before. I would like to put this into jEdit 5.0 so that plugins can use it sooner (esp. projectviewer which has duplicate bad code right now).

Submitted:

Alan Ezust ( ezust ) - 2012-06-10 11:41:39 PDT

Priority:

Status:

Closed

Resolution:

Accepted

Assigned:

Jarek Czekalski

Category:

None

Group:

for 5.0.x

Visibility:

Public

Comments ( 10 )

Date: 2012-07-01 08:53:41 PDT Sender: jarekczek Applied to 5.0 as r21894. It would be easier if there were no other changes to the method applied inbetween and no whitespace changes in different places.
Date: 2012-06-26 14:41:03 PDT Sender: ezust Rev# 21880 should address all your issues.
Date: 2012-06-26 07:22:36 PDT Sender: jarekczek Alan, with such hasty comment and this level of your verbosity I see no way to work on this ticket. And my opinion about this new api in 5.1 remains negative.
Date: 2012-06-25 10:17:52 PDT Sender: ezust That is incorrect. An IOException can also be thrown from Runtime.exec(). if for example, command is not found or filename is bad.
Date: 2012-06-25 10:12:23 PDT Sender: jarekczek There is a problem with method's signature, maybe with javadoc. @throws IOException if the path is not valid or something else is not working Usually the exception will not be thrown because the string is simply passed to a native command. Only in // I don't know what platform it is... there may really be IOException raised. But that's the border case, as all known operating systems don't reach this line. I think it would be better to remove this misleading exception from signature. Capture it and report immediately, maybe returning true on success, false on failure. Copying the code from action to api seems to be not enough in this case. Api needs additional care.
Date: 2012-06-17 08:07:00 PDT Sender: jarekczek Kazutoshi was not sure whether to agree on this merge. I am going to commit it, but will wait a few days for possible objections.
Date: 2012-06-14 10:47:18 PDT Sender: ezust Rev#21801 improves the API docs for the function.
Date: 2012-06-11 11:11:09 PDT Sender: ezust I hope an exception can be made in this case. I was just a day late :-)
Date: 2012-06-11 10:27:35 PDT Sender: jarekczek Alan, so you suggest that 5.0pre1 (already released) have different api than 5.0 or 5.0pre2? I remember someone said recently that it shouldn't be done, but I don't see any written rule about that.
Date: 2012-06-11 10:12:46 PDT Sender: ezust I removed some unnecessary code in rev# 21792 so you can apply that as part of this merge request too.

Attached File

Changes ( 6 )

Field	Old Value	Date	By
status_id	Open	2012-07-01 08:53:41 PDT	jarekczek
resolution_id	None	2012-07-01 08:53:41 PDT	jarekczek
assigned_to	nobody	2012-07-01 08:53:41 PDT	jarekczek
close_date	-	2012-07-01 08:53:41 PDT	jarekczek
assigned_to	jarekczek	2012-06-26 07:22:36 PDT	jarekczek
assigned_to	nobody	2012-06-17 08:07:00 PDT	jarekczek

jEdit

Tracker: Merge Requests

Comments ( 10 )

Attached File

No Files Currently Attached

Changes ( 6 )