Tracker: Bugs

5 please apply hiphop patch - ID: 3394168
Last Update: Settings changed ( bagder )

Here it is: https://raw.github.com/facebook/hiphop-php/master/src/third_party/libcurl.fb-changes.diff Also attached.

Mark A. Hershberger ( hexmode ) - 2011-08-18 15:34:58 PDT

5

Closed

Invalid

Daniel Stenberg

libcurl

new feature request

Public


Comment ( 1 )

Date: 2011-08-19 00:33:46 PDT
Sender: bagderProject AdminAccepting Donations

Thanks,

If FD_SETSIZE is a problem you're using a very large amount of file
descriptors. If you're using a large amount of file descriptors then poll()
is also very slow and a bad choice. Hence libcurl provides the multi_socket
API to allow the app to work around both the FD_SETSIZE problem as well as
completely avoiding slow functions such as poll() and select().

I'm not seeing the major benefit of this function.

If you still think this is good stuff for libcurl, then I would like to see
that you motivate and explain your patch and reasoning on the curl-library
list so that we can discuss pros and cons and see what others think and how
to proceed. (The patch also lacks documentation and test cases.)

This is not a bug, so this bug entry will be closed.

Attached File ( 1 )

Filename Description Download
libcurl.fb-changes.diff The patch Download

Changes ( 7 )

Field Old Value Date By
close_date 2011-08-19 00:33 2011-09-06 13:11:50 PDT bagder
allow_comments 1 2011-09-06 13:11:50 PDT bagder
status_id Pending 2011-09-06 13:11:50 PDT bagder
close_date - 2011-08-19 00:33:47 PDT bagder
resolution_id None 2011-08-19 00:33:47 PDT bagder
status_id Open 2011-08-19 00:33:47 PDT bagder
File Added 421497: libcurl.fb-changes.diff 2011-08-18 15:35:01 PDT hexmode