Tracker: Patches

5 Patch for Mono 4.0 profile - ID: 3206199
Last Update: Comment added ( rmboggs )

Here is a patch in order to build NAnt for the Mono-4.0 profile. It was generated against the trunk at today's date.

I have identified two issues:
- Assembly.LoadFrom(String, Evidence) is deprecated in .NET 4.0. I have decorated the calls with an #ifdef.
- Mono reports a CS0419 error in a comment because of overlads of Path.Combine. I have remove the cref tag and decorate the comment with an #ifdef.


Laurent Etiemble ( letiemble ) - 2011-03-11 00:56:26 PST

5

Closed

Fixed

Ryan Boggs

Core

Current CVS

Public


Comments ( 7 )

Date: 2011-10-19 07:09:46 PDT
Sender: rmboggsProject Admin

I know this went in awhile ago (probably 0.91 Beta1). Just forgot to
resolve this patch request.


Date: 2011-05-05 00:04:19 PDT
Sender: letiembleSourceForge.net DonorAccepting Donations

I vote to remove the see tag as it is the simpliest solution and avoids an
#ifdef lost in the comments.


Date: 2011-05-04 11:50:19 PDT
Sender: rmboggsProject Admin

This should now be in head. The only problem I had was with the #ifdef
around the comment. I rec'd errors when compiling on .NET. I might have
to either restructure it some more or remove the <see> tag from the comment
entirely.


Date: 2011-03-13 21:37:23 PDT
Sender: rmboggsProject Admin

I committed this to my branch for further review.


Date: 2011-03-13 10:48:27 PDT
Sender: rmboggsProject Admin

Much better, thank you. It looks straight forward and I have merged it
into my local checkout. However, while reviewing this, I started seeing
other areas with similar situations like this that could affect building
NAnt on .NET 4.0. So it may be a bit before it is committed to my branch
while I address those areas, but I am working on it.


Date: 2011-03-13 01:18:28 PST
Sender: letiembleSourceForge.net DonorAccepting Donations

I have attached the patch made with the -uNR options. Indeed, it is easier
to review.


Date: 2011-03-11 12:44:20 PST
Sender: rmboggsProject Admin

Thanks for this Laurent but do you think you can recreate the diff using
-uNR please. It makes it easier for me to review.


Attached File ( 1 )

Filename Description Download
mono-4.0.diff Mono 4.0 profile diff (-uNR) Download

Changes ( 9 )

Field Old Value Date By
status_id Open 2011-10-19 07:09:46 PDT rmboggs
close_date - 2011-10-19 07:09:46 PDT rmboggs
allow_comments 1 2011-10-19 07:09:46 PDT rmboggs
resolution_id Accepted 2011-10-19 07:09:46 PDT rmboggs
resolution_id None 2011-03-13 21:37:23 PDT rmboggs
assigned_to nobody 2011-03-13 10:48:27 PDT rmboggs
File Deleted 404023: 2011-03-13 01:17:41 PST letiemble
File Added 404197: mono-4.0.diff 2011-03-13 01:17:29 PST letiemble
File Added 404023: mono-4.0.diff 2011-03-11 00:56:27 PST letiemble