I looked into these tests and found they does not use transport and marshal libraries.
Instead of it they use openhpi daemon library which does not require marshalling and network sending.
Could you bring some details of any failed test case?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
the build of a pre-2.15.1 rpm in chroot fails with
...
make check-TESTS
make[4]: Entering directory `/builddir/build/BUILD/openhpi-2.15.1/openhpid/t/ohpi'
/builddir/build/BUILD/openhpi-2.15.1/openhpid/t/ohpi/.libs/lt-ohpi_007: error while loading shared libraries: libopenhpimarshal.so.2: cannot open shar
ed object file: No such file or directory
FAIL: ohpi_007
...
but it can be problem when something is over-linked. I will do a build with "-Wl,--as-needed" that will use only the libraries that are really needed to resolve missing symbols and won't use the whole "-lfoo -lbar ..." set.
Also when doing a non-chroot build the missing library can be found in system /usr/lib and the test suite is run.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
update LD_LIBRARY_PATH v2
libopenhpimarshal is also needed
Looks fine.
Suggest to commit in trunk and change ticket group to 2.15.x
I looked into these tests and found they does not use transport and marshal libraries.
Instead of it they use openhpi daemon library which does not require marshalling and network sending.
Could you bring some details of any failed test case?
the build of a pre-2.15.1 rpm in chroot fails with
...
make check-TESTS
make[4]: Entering directory `/builddir/build/BUILD/openhpi-2.15.1/openhpid/t/ohpi'
/builddir/build/BUILD/openhpi-2.15.1/openhpid/t/ohpi/.libs/lt-ohpi_007: error while loading shared libraries: libopenhpimarshal.so.2: cannot open shar
ed object file: No such file or directory
FAIL: ohpi_007
...
but it can be problem when something is over-linked. I will do a build with "-Wl,--as-needed" that will use only the libraries that are really needed to resolve missing symbols and won't use the whole "-lfoo -lbar ..." set.
Also when doing a non-chroot build the missing library can be found in system /usr/lib and the test suite is run.
The patch is attached.
make check and make distcheck went well on my system.
Could you try it?
Tried "make check" and "make rpm" on the system without pre-installed OpenHPI.
It worked.
Fixed in trunk (rev #7188)
I wasn't successful with the unnecessary_libs.diff patch (not sure what went wrong), but have no problems with rev 7189 in the 2.15.x branch.
OK. great then!