Tracker: Feature Requests

5 When reviewing, "no Line XXX" link available - ID: 2710230
Last Update: Comment added ( gabb99 )

Fresh install of 1.9.8

When reviewing, "no chunk diff" comment link available.
The "Parallel" link and Topic comment is working on both sides though.
The individual line links are also working on both sides.



Gabriel Beauchemin ( gabb99 ) - 2009-03-24 12:14:25 PDT

5

Open

None

Nobody/Anonymous

None

None

Public


Comments ( 8 )

Date: 2009-03-27 07:53:20 PDT
Sender: gabb99

Documentation should be updated to "remove" this feature. The individual
line links do work, and this is what we will use, since, as you stated,
many bugs were fixed, and major improvments were made, so a rollback is not
an option. Thanks for your time.


Date: 2009-03-24 18:47:43 PDT
Sender: sitsProject Admin

You'll need 1.9.4, but I wouldn't recommend it, as I imagine a large number
of bugs have been fixed since that release. Can't you just use the
Parallel view and use the horizontal scrollbar to position the view
appropriately?



Date: 2009-03-24 18:04:02 PDT
Sender: nobody

It's important enough to maybe rollback to the working version. What's the
last version where the line links did work ?

tia,
gabB


Date: 2009-03-24 16:26:59 PDT
Sender: nobody

That is - the line links have "not been supported" for a few releases now.



Date: 2009-03-24 16:26:22 PDT
Sender: nobody

The "Line XXX" links have been supported for a few releases now, since the
rendering code was massively refactored. At the moment, only Parallel
links are supported.

Do you find the "Line XXX" links useful?



Date: 2009-03-24 16:15:22 PDT
Sender: nobody

Sorry if I wasn't clear enough.
When doing a codestrike, there's no link to add a comment for the diff
block (the Line xxx link, beside the Parallel link).

The comment links do however work at the topic level (ie: for the whole
review), and at the individual line level. Please look at the attachment.
"Line 1" isn't underscored as it should be. I've also pasted the relevant
html code (using Firefox or Safari).


Date: 2009-03-24 15:12:04 PDT
Sender: nobody

Sorry I am confused.. what exactly is the problem? Can you give more
information?



Date: 2009-03-24 12:16:45 PDT
Sender: gabb99

Snippet of the html, which show that it's mising a bit of html.

<td class="line" colspan="2">
Line 1
|
<a href="javascript:
myOpen('http://codestriker.dev.stw/codestriker/codestriker.pl?action=view_file&fn=0&topic=8531826&new=0&mode=1#0|1|0',
'Codestriker')">
Parallel
</a>

</td>
<td class="line" colspan="2">
Line 1
|
<a href="javascript:
myOpen('http://codestriker.dev.stw/codestriker/codestriker.pl?action=view_file&fn=0&topic=8531826&new=1&mode=1#0|1|1',
'Codestriker')">
Parallel
</a>
</td>
</tr>



Attached File ( 1 )

Filename Description Download
Nolink.png No link available Download

Changes ( 3 )

Field Old Value Date By
data_type 429863 2009-03-24 18:47:43 PDT sits
summary When reviewing, "no chunk diff" comment link available 2009-03-24 18:47:43 PDT sits
File Added 319390: Nolink.png 2009-03-24 12:14:25 PDT gabb99