Codestriker: collaborative code reviewer

Yes you are right - that is one way of fixing it, however that "rss"
parameter is deprecated now.

I've committed in the proper fix in ListTopicsMethod.pm which just switches
on the action parameter instead. I've confirmed that it actually does work
properly now. I'll make a rc3 build with this fix in it.

1.9.7-rc-2
Still does not work... I had to add this:
File: UrlBuilder.pm
Fuction: list_topics_url_rss
Added line: $args{rss} = 1;

Thanks for that - should be fixed now. Here is the patch below since it is
so simple.

Index: lib/Codestriker/Http/Method/ListTopicsMethod.pm
===================================================================
RCS file:
/cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/ListTopicsMethod.pm,v
retrieving revision 1.6
diff -u -r1.6 ListTopicsMethod.pm
--- lib/Codestriker/Http/Method/ListTopicsMethod.pm 8 Sep 2008 10:19:50
-0000 1.6
+++ lib/Codestriker/Http/Method/ListTopicsMethod.pm 11 Oct 2008 00:23:13
-0000
@@ -83,7 +83,13 @@
sub execute {
my ($self, $http_input, $http_output) = @_;

- Codestriker::Action::ListTopics->process($http_input, $http_output);
+ my $action = $http_input->{query}->param('action');
+ if ($action eq "list_topics_rss") {
+ Codestriker::Action::ListTopicsRSS->process($http_input,
$http_output);
+ } else {
+ Codestriker::Action::ListTopics->process($http_input,
$http_output);
+ }
+
}

1;