Tracker: Bugs

5 autoconf version, compile warnings, doco improvements - ID: 2035993
Last Update: Comment added ( quadong )

1. when doing a release, update the version in configure.ac and regenerate configure as this affects the output of l7-filter --help

2.
few compile warning that i've ignored for the time being. The first one will probably cause gcc faults in the new releases (tested with 4.2.3)

l7-classify.cpp: In function 'char** readl7dir(std::string)':
l7-classify.cpp:160: warning: deprecated conversion from string constant to 'char*'


l7-filter.cpp: In function 'void handle_cmdline(int&, std::string&, int, char**)':
l7-filter.cpp:174: warning: comparison is always false due to limited range of data type
l7-filter.cpp:174: warning: comparison is always false due to limited range of data type
l7-filter.cpp:181: warning: comparison is always false due to limited range of data type
l7-filter.cpp:181: warning: comparison is always false due to limited range of data type
l7-filter.cpp:193: warning: comparison is always false due to limited range of data type
l7-filter.cpp:193: warning: comparison is always false due to limited range of data type

3. Path changes should be done with ./configure as this can propergate to other aspects of the compile.
I think by default it looks in /usr/local/lib and /usr/lib however I don't think changing PREFIX here changes where to look for libs. Adding -L{path} to LDFLAGS is the proper way to where to look for libs.

As configure.ac uses PKG_CHECK_MODULES([NFNETLINK], [libnetfilter_conntrack libnetfilter_queue]) and hence the ${libdir}pkgconfig/libnetfilter_queue.pc to find the libraries I don't imagine this is going to cause anyone any problems. If you want a hand adding options I'm happy to help.

4. small automake to install doco by default. Previous DOC= didn't do anything sorry.


Daniel Black ( grooverdan ) - 2008-08-02 08:43:05 PDT

5

Closed

Accepted

Nobody/Anonymous

userspace

None

Public


Comment ( 1 )

Date: 2008-08-31 23:47:10 PDT
Sender: quadongProject Admin


I've applied 1, 3, and 4. I removed the silly checks that I believe are
generating the second batch of warnings and made a comment on the first
one.


Attached File ( 1 )

Filename Description Download
l7-filter-0.8-misc.patch l7-filter-0.8-misc.patch Download

Changes ( 4 )

Field Old Value Date By
status_id Open 2008-08-31 23:47:10 PDT quadong
resolution_id None 2008-08-31 23:47:10 PDT quadong
close_date - 2008-08-31 23:47:10 PDT quadong
File Added 286832: l7-filter-0.8-misc.patch 2008-08-02 08:43:06 PDT grooverdan