Tracker: Bugs

5 File links at the top point to an ambiguous anchor - ID: 1889383
Last Update: Comment added ( sits )

The links to files at the top of a code review page go to an anchor with the same name as the path to the file.

Problem is, this anchor occurs twice in the HTML -- once at the top, once at the bottom.

Opera happens to choose the bottom one, so clicking on any file link will invariably take me to the bottom of the review for that file. Firefox presumably chooses the top. To remove the ambiguity, the one at the bottom should probably be removed.

Trejkaz ( trejkaz ) - 2008-02-07 19:53:16 PST

5

Closed

Fixed

Nobody/Anonymous

None

None

Public


Comments ( 2 )

Date: 2008-03-16 19:52:54 PDT
Sender: sitsProject Admin


Fixed so only the top anchor is displayed - will be available in the next
release.

Date: 2008-02-26 02:02:31 PST
Sender: rob_webset


The simplest fix for this is:

File: Render.pm
Method: _coloured_mode_finish

Remove the following code:

if ($self->{fview} != -1) {
# Show the current file header again for navigation purposes when
# viewing a single file at a time.
$self->delta_file_header($self->{diff_current_filename},
$self->{diff_current_revision},
$self->{diff_current_repmatch});
}

This would remove the bottom bar at the end of the single file view.

This would also solve the problem that the top bar spans the whole of the
width of the code review, and the bottom one just spans the viewable
screen.

Attached File

No Files Currently Attached

Changes ( 3 )

Field Old Value Date By
status_id Open 2008-03-16 19:52:54 PDT sits
resolution_id None 2008-03-16 19:52:54 PDT sits
close_date - 2008-03-16 19:52:54 PDT sits