Menu

#156 Wiki says "page not found" if query string is "?page="

closed-fixed
None
1
2005-02-28
2004-12-31
No

I've found a minor bug in the Wiki feature of Tiki 1.8.
It's probably in later versions too.

The problem is if the Wiki page (tiki-index.php) is
called with a "page=" in the query string (or in post
data) that is empty. Eg.

http://example.com/tiki-index.php?page=

In this case, Tiki returns an error, saying the page
does not exist. Since pages can't have an empty name,
the home page should be returned, rather than an error.
The fix is trivial:

# diff tiki-index.php tiki-index.php.bugged
39c39
< if((!isset($_REQUEST["page"])) || ($_REQUEST["page"]
== "")) {
---
> if(!isset($_REQUEST["page"])) {

(all on line 39 of (my) tiki-index.php)

Fixing this makes SEFURLs work *much* easier! ;-)
(among other things)

...Coofer Cat

Discussion

  • Michael Davey

    Michael Davey - 2005-02-26
    • priority: 5 --> 1
    • assigned_to: nobody --> michael_davey
    • status: open --> pending-accepted
     
  • Michael Davey

    Michael Davey - 2005-02-26

    Logged In: YES
    user_id=399326

    I fixed this a different way a few weeks ago in my personal
    development environment. As it requires other usability
    improvements, it hasn't been committed yet.

    I'll update this tracker when the fix is public.

     
  • Michael Davey

    Michael Davey - 2005-02-28

    Logged In: YES
    user_id=399326

    Fix committed to CVS BRANCH-1-9 for tiki-index.php and
    tiki-editpage.php on Feb. 11th:

    http://sourceforge.net/mailarchive/message.php?msg_id=10838768

     
  • Michael Davey

    Michael Davey - 2005-02-28
    • status: pending-accepted --> closed-fixed
     

Log in to post a comment.