Tracker: Bugs

5 Creating topic using subversion with 'propset' diffs fails - ID: 1025199
Last Update: Settings changed ( sits )

When creating a new topic using a subversion diff that
includes a 'propset' entry, the topic is not created
correctly.

The scenarios differ slightly depending on whether a
direct subversion source connection is used or if text
upload is used. If a direct subversion source
connection is used, there is no topic text (diffs)
included in the topic. If text upload is used, the
uploaded text file is shown as the only topic text
instead of it being parsed into the correct topic files.

An example of the 'propset' entry in subversion diffs is:

Property changes on: webapps/WEB-INF/struts-tiles.tld
___________________________________________________________________
Name: svn:eol-style
+ native


To add a property in subversion that will generate the
above diff message, run the following command:

svn propset svn:eol-style native 'filename'


Keith Levy ( kmlevy ) - 2004-09-09 08:30:58 PDT

5

Closed

Fixed

Nobody/Anonymous

None

None

Public


Comments ( 8 )

Date: 2004-09-13 03:17:53 PDT
Sender: sitsProject Admin

Logged In: YES
user_id=208928

I have modified lib/Codestriker/FileParser/SubversionDiff.pm
so that it can now handle diffs with propset changes in
them. This is now in CVS, and just made it into the 1.8.3
release, which is due out tomorrow morning. Thanks for
uploading the example diffs. Hopefully this has fixed your
problem.




Date: 2004-09-10 07:17:34 PDT
Sender: kmlevy

Logged In: YES
user_id=1118904

uploading 5th file


Date: 2004-09-10 07:17:06 PDT
Sender: kmlevy

Logged In: YES
user_id=1118904

uploading 4th file


Date: 2004-09-10 07:16:44 PDT
Sender: kmlevy

Logged In: YES
user_id=1118904

uploading 3rd file, 2nd try


Date: 2004-09-10 07:15:55 PDT
Sender: kmlevy

Logged In: YES
user_id=1118904

uploading 3rd file


Date: 2004-09-10 07:15:30 PDT
Sender: kmlevy

Logged In: YES
user_id=1118904

uploading 2nd file


Date: 2004-09-10 07:14:43 PDT
Sender: kmlevy

Logged In: YES
user_id=1118904

I have attached 5 diff files:

svnPropDiff1.txt - shows one file with a property change
svnPropDiff2.txt - shows same file with a different property
change
svnPropDiff3.txt - shows diff of same file across both
property changes (note all changes are under the same header)
svnPropDiff4.txt - shows diffs of multiple files including
single property change
svnPropDiff5.txt - shows diffs of multiple files including
multiple property changes


Date: 2004-09-09 21:15:26 PDT
Sender: sitsProject Admin

Logged In: YES
user_id=208928

I don't have subversion running on any of my machines at the
moment. Could you attach an example diff file which shows
just a property set change, and files which have both code
and property set changes? Thanks.

The more examples you can provide in a diff file, the
better. If you can attach it as a file, that would be best,
so that there are no line-wrapping spacing issues.




Attached Files ( 5 )

Filename Description Download
svnPropDiff1.txt Download
svnPropDiff2.txt Download
svnPropDiff3.txt Download
svnPropDiff4.txt Download
svnPropDiff5.txt Download

Changes ( 10 )

Field Old Value Date By
close_date - 2004-09-13 03:18:32 PDT sits
status_id Open 2004-09-13 03:18:32 PDT sits
resolution_id None 2004-09-13 03:17:53 PDT sits
File Added 101015: svnPropDiff5.txt 2004-09-10 07:17:34 PDT kmlevy
File Added 101014: svnPropDiff4.txt 2004-09-10 07:17:06 PDT kmlevy
File Added 101013: svnPropDiff3.txt 2004-09-10 07:16:44 PDT kmlevy
File Deleted 101012: 2004-09-10 07:15:55 PDT kmlevy
File Added 101012: svnPropDiff2.txt 2004-09-10 07:15:30 PDT kmlevy
File Added 101011: svnPropDiff2.txt 2004-09-10 07:15:07 PDT kmlevy
File Added 101010: svnPropDiff1.txt 2004-09-10 07:14:43 PDT kmlevy