LAME (Lame Aint an MP3 Encoder) / Bugs / #331 lame_encode_flush() returns -1

#331 lame_encode_flush() returns -1

Milestone: Compatibility

Status: closed-fixed

Owner: Robert Hegemann

Labels: Libraries (86)

Priority: 1

Updated: 2009-04-13

Created: 2009-01-31

Creator: wzrlpy

Private: No

Hi,

As a result of investigating issue 803 in FFMpeg (http://roundup.ffmpeg.org/roundup/ffmpeg/issue803), we found that in version 3.98.2, or in the latest CVS (tried 2008-01-29), the lame_encode_flush() sometimes return -1, but lame.h does not document it.

Version 3.98 does not return -1.

Is this a bug or an undocumented feature?

Regards and thanks for your support.

Discussion

Robert Hegemann - 2009-02-02

A negative return value signals a fatal error, in this case it signals "buffer too small".

Ciao Robert

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2009-02-02

priority: 5 --> 1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2009-02-03

Hi Victor,

it isn't really a bug inside LAME library, it's just not well documented in lame.h.

Ciao Robert

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Artem Russakovskii - 2009-02-10

I've been experiencing this bug with a large number of various file formats, while it's not present at all in 3.97, so something in the new lame is causing this. I'll be interested in a solution, but in the meantime I've restricted all of our lame updates to 3.97.

Artem
http://beerpla.net
http://twitter.com/ArtemR

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nobody/Anonymous - 2009-03-21

http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/84314

could you please appease the FFMPEG devs so that current and future versions of Lame libraries do work with that bugless piece of software?

regards,
andrea

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2009-03-24

If I find some time, I'll add a workaround for the FFMPEG bug. Maybe it will be in 3.98.3, to be released sometime this year.

Note: FFMPEG seems to be calling lame_encode_flush in a loop, instead of once only.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2009-03-24

assigned_to: nobody --> robert
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2009-03-29

I just committed to CVS some workaround for the FFMPEG bug. It's in to LAME 398 bug fix branch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Robert Hegemann - 2009-03-29

status: open --> pending-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2009-04-13

status: pending-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2009-04-13

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.