Menu

#2558 [PATCH] Fix character-level line differences highlighting

Trunk
closed-accepted
nobody
5
2008-06-02
2008-05-13
No

This patch is for bug 1883409 (https://sourceforge.net/tracker/?func=detail&atid=113216&aid=1883409&group_id=13216)

It fixes wordLevelToByteLevel() for the case when text is found in only one of the 2 compared strings either at the end or beginning of an existing word. (See sample files attached to https://sourceforge.net/tracker/?func=detail&atid=113216&aid=1883409&group_id=13216\)

Discussion

  • Marcel Gosselin

    Marcel Gosselin - 2008-05-13

    [PATCH] Fix wordLevelToByteLevel()

     
  • Kimmo Varis

    Kimmo Varis - 2008-05-13

    Logged In: YES
    user_id=631874
    Originator: NO

    Thanks a lot for the patch. Seems simple and obvious. I'll run some tests later today and apply it.

     
  • Kimmo Varis

    Kimmo Varis - 2008-05-15

    Logged In: YES
    user_id=631874
    Originator: NO

    Sorry it took couple of days, been busy with other stuff. :(

    I quickly tested this patch and didn't see anything weird, so I'll commit this in couple of minutes..

     
  • Kimmo Varis

    Kimmo Varis - 2008-05-15
    • status: open --> open-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2008-05-15

    Logged In: YES
    user_id=631874
    Originator: NO

    Committed to SVN trunk:
    Completed: At revision: 5343

    I'll leave this open for later 2.8 branch commit.

     
  • Kimmo Varis

    Kimmo Varis - 2008-06-02

    Logged In: YES
    user_id=631874
    Originator: NO

    Committed to 2.8 branch:
    Completed: At revision: 5414

    Closing.

    Thanks again for the patch!

     
  • Kimmo Varis

    Kimmo Varis - 2008-06-02
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.