fsck -A -C3 does not report progress for multiple partitions
Brought to you by:
tytso
Menu
▾
▴
#213 fsck -A -C3 does not report progress for multiple partitions
I'm currently working on reporting fsck progress in a graphical boot system (Ubuntu's "usplash"), where I utilize the fsck option -C3 to report machine readable progress information. However, when checking multiple partitions at the same time, only the first partition is reported on the FD, the others remain silent:
--- fstab ---
/dev/sda1 /mnt ext3 defaults 0 2
/dev/sdb1 /media/f ext3 defaults 0 2
--- fstab ---
# tune2fs -C 31 /dev/sda1
# tune2fs -C 39 /dev/sdb1
# fsck -C3 -R -A 3>&1
fsck 1.40.8 (13-Mar-2008)
/dev/sdb1 has been mounted 39 times without being checked, check forced.
PittiUSB has been mounted 31 times without being checked, check forced.
1 0 8
[... continuing progress information for sda1 ...]
5 16 16
PittiUSB: 467/16128 files (2.1% non-contiguous), 50902/64488 blocks
[... looooong pause here ... ]
/dev/sdb1: 100502/366528 files (0.1% non-contiguous), 557664/732957 blocks
("PittiUSB" is the label of /dev/sda1)
I would expect that progress report continues for /dev/sdb1, with "1 0 1" again.
On a related note, it would be great if the output would contain the currently checked device (as fourth field perhaps), since parsing it out of "ps" is a bit hackish; that's just an unrelated wishlist item, though).
Thank you in advance!
Martin
Logged In: YES
user_id=80975
Originator: YES
For the record, this does not only affect progress report to an FD ("-C3"), but also the progress bar when using just "-C".
Logged In: YES
user_id=628
Originator: NO
Can you test these patches and let me know how well (or poorly) they work?
Thanks!!
File Added: sf-196023-patches.zip
Logged In: YES
user_id=80975
Originator: YES
I just tested them, and they work perfectly. Thanks a lot for this super-fast response! I owe you one.
I also tested 0005-e2fsck-Include-the-device-name-in-the-progress-info.patch, it works well, too. I'm just a little hesitant to apply it to the Ubuntu package at this stage, since it changes the output, and thus violates feature freeze. However, in the next release I'll gladly adapt the fsck usplash integration scripts to the four-column output, which should make the code much easier.
Thanks again!
Martin
Logged In: YES
user_id=628
Originator: NO
Great! I'm glad these patches are useful for you. All of them will be in e2fsprogs 1.40.9. It's too bad I didn't have a chance to IM with you before you released the updated e2fsprogs, as there were two other patches that would have been nice to get into Ubuntu hardy:
http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commit;h=a2ff0f31c1987a480ffc4dacb7adf93f0aecf7f6
(debugfs, tune2fs: Handle daylight savings time when parsing a time string)
http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commit;h=1e8757dd5e108817ac28b77f209f4baa2848547c
(po: update de.po (from translationproject.org) -- there were a bunch of really bad German translation issues that got fixed here, including a number of long-standing Debian bugs.)
Oh, well, I guess they're not that critical, and they can always get fixed in an bugfix update in the future.
(Or, if I can convince Ubuntu to accept an upgrade to 1.41 for Hardy so people can use ext4 successfully at some point in the future, all of these fixes will be in 1.41 as well. They are currently in the maint branch for 1.40.9, but of course these get pulled as well into the devel branch for the next major release, 1.41.)
Best regards,