Menu

#1512 Unexpected backspace key handling in rename

Branch_+_Trunk
closed-accepted
Usability (119)
5
2007-12-09
2007-06-17
Anonymous
No

WinMerge 2.6.6.0 Unicode

Summary: When renaming a file, the backspace key will change view to parent directory instead of deleting character to left of cursor.

Context: Open WinMergeU.exe with two directories similar to: C:\temp\counter\ & D:\counter\ . Right-click on a file and select Rename from context menu. Press end key (or place cursor after last character of filename) and then press backspace key. View is changed to parent directories: C:\temp\ & D:\

Workaround: reposition cursor and use delete key.

Discussion

  • Gal Hammer

    Gal Hammer - 2007-06-18

    Logged In: YES
    user_id=411238
    Originator: NO

    Such a small feature, so many bugs. :-(

    I'll handle it.

     
  • Kimmo Varis

    Kimmo Varis - 2007-06-18
    • milestone: --> Branch_+_Trunk
    • assigned_to: nobody --> galh
     
  • Kimmo Varis

    Kimmo Varis - 2007-06-18

    Logged In: YES
    user_id=631874
    Originator: NO

    What do you think about fix, would it be too big change to immediately apply to 2.6 branch? I really want to get 2.6.8 out in couple of days...

    Though these key handlings seem to be constant area of regressions. So maybe better not to push this too fast to stable.. Granted, current behavior surprises user, but that's better than crash..

     
  • Gal Hammer

    Gal Hammer - 2007-11-26

    Logged In: YES
    user_id=411238
    Originator: NO

    Attached is a bug fix. I now first check if the rename edit box exist before handing the WM_KEYDOWN message.
    File Added: FixDirView.7z

     
  • Gal Hammer

    Gal Hammer - 2007-11-26

    Bug fix patch

     
  • Kimmo Varis

    Kimmo Varis - 2007-11-26

    Logged In: YES
    user_id=631874
    Originator: NO

    Makes sense, can you commit this in couple of days for next beta?

    Btw, you have folders mixed in patch - confused me a bit to have modified code in 'original' folder :)

     
  • Gal Hammer

    Gal Hammer - 2007-11-26

    Logged In: YES
    user_id=411238
    Originator: NO

    No problem, I'll commit it soon.

    Don't blame my folders, it's the 7-zip plug-in that I never seem to execute properly. :-)

     
  • Gal Hammer

    Gal Hammer - 2007-11-27

    Logged In: YES
    user_id=411238
    Originator: NO

    Committed to SVN. Completed: At revision: 4797.

    I'll back port the fix to R2_6 branch after the beta release.

     
  • Kimmo Varis

    Kimmo Varis - 2007-12-08
    • status: open --> open-accepted
     
  • Kimmo Varis

    Kimmo Varis - 2007-12-08

    Logged In: YES
    user_id=631874
    Originator: NO

    Ok, can you commit this to 2.6 branch?

     
  • Gal Hammer

    Gal Hammer - 2007-12-09

    Logged In: YES
    user_id=411238
    Originator: NO

    Committed to R2_6 branch. Completed: At revision: 4820.

    Closing.

     
  • Gal Hammer

    Gal Hammer - 2007-12-09
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.