Menu

#83 Support CSV files from a URL (e.g. jar file) + CSV fixes

closed-fixed
Bug (232)
5
2008-06-14
2005-02-02
No

I've added support for CSV files coming from a URL.

I've also fixed the existing implementation of
CsvDataSet/CsvProducer/CsvDataSetWriter where:

1)CsvProducer didn't honour the table ordering file.
2)CsvProducer didn't honour the 'null' string.

These caused ant tasks that needed the ordering file or
null support to fail.

3) CsvDataSet was an unordered dataset by default.
4) CsvDataSet was responsible for writing the
table-ordering.txt file, something CsvDataSetWriter
should have done.

There are tests for the new/changed classes.

In the zip file are three files:
csv-url-support.txt - a unified diff patch file.
mm.mysql-2.0.11-bin.jar - a file missing from /lib
orders.jar - a test file which should be placed in
src/csv/orders.

Discussion

  • dion gillard

    dion gillard - 2005-02-03
     
  • Eric Pugh

    Eric Pugh - 2005-05-06

    Logged In: YES
    user_id=140549

    Dion, I am committing your fix. I had to fix the name of
    one of the source files from order_row to orders_row, and
    also, I didn't seem to need the mm.mysql-2.0.11-bin.jar to
    get the tests to pass, so I skipped it.

    Please review and let me know. Sorry about being so slow to
    commit these fixes.

     
  • dion gillard

    dion gillard - 2005-05-06

    Logged In: YES
    user_id=36058

    I'll check after you've committed if you like.

    As long as the tests pass, it should all be ok.

    I'll definitely check it out and confirm it works. Thanks!

     
  • Roberto Lo Giacco

    • status: open --> closed-fixed
     
  • Roberto Lo Giacco

    Logged In: YES
    user_id=57511
    Originator: NO

    Almost 3 years have passed! I think this issue can be considered fixed and closed unless someone doesn't have any followup...

     
  • Roberto Lo Giacco

    • labels: --> Bug
     

Log in to post a comment.