-
The null pointer check for the pointer "data" is not needed in a function.
http://opengroup.org/onlinepubs/009695399/functions/free.html
I suggest to adjust its implementation like the following.
http://w3m.cvs.sourceforge.net/viewvc/w3m/w3m/w3mimg/fb/fb.c?revision=1.16&view=markup
fb_image_free(FB_IMAGE * image)
{
if (image == NULL)
return;
free((image->data);...
2009-11-27 18:30:48 UTC by elfring
-
This is a variant for my previous bug report #1675788.
2009-11-27 16:28:16 UTC by elfring
-
Would you like to replace any defines for constant values by enumerations to stress their relationships?
http://w3m.cvs.sourceforge.net/viewvc/w3m/w3m/menu.h?revision=1.2&view=markup
http://w3m.cvs.sourceforge.net/viewvc/w3m/w3m/terms.h?revision=1.10&view=markup
http://w3m.cvs.sourceforge.net/viewvc/w3m/w3m/libwc/ces.h?revision=1.2&view=markup.
2009-11-27 16:20:43 UTC by elfring
-
I suggest to try the search pattern "\
2009-11-27 16:06:26 UTC by elfring
-
Some checks for return codes are missing.
Examples:
Would you like to add more error handling for return values from "XSetForeground" like in the function "x11_img_new" and from "fprintf" in the function "save_cookies"?
http://w3m.cvs.sourceforge.net/viewvc/w3m/w3m/w3mimg/x11/x11_w3mimg.c?revision=1.29&view=markup...
2009-11-27 15:34:41 UTC by elfring
-
Maybe the cause is the value for "Accept header" in your w3m
configuration (accept_media in your ~/.w3m/config). If it contains
"text/*" and not "text/html" and also not "*/*" and the HTTP response
(use -dump_both) contains:
HTTP/1.0 406 Not Acceptable
Content-Type: text/html; charset=utf-8
Vary: Accept-Encoding
then you've encountered 3 stupidities in one response:
- text/* should...
2009-10-21 16:38:56 UTC by metaf2xml
-
For source code file w3m-0.5.2/buffer.c
function readBufferCache
I notice the following code
cache = fopen(buf->savecache, "r");
if (cache == NULL || fread1(clnum, cache) || fread1(tlnum, cache)) {
buf->savecache = NULL;
return -1;
}
so if the return is taken, then cache is a resource leak.
Suggest new code
cache = fopen(buf->savecache, "r");.
2009-10-21 12:43:42 UTC by dcb314
-
You should really describe the issue in greater detail.
2009-08-07 15:14:57 UTC by louipc
-
Does the -cols switch solve it?.
2009-08-07 15:08:01 UTC by louipc
-
Very nice site! [url=http://oixapey.com/rqaavs/2.html]cheap cialis[/url].
2009-07-31 22:44:29 UTC by nobody
