-
Fixed in the revisions 4069-4071 in the form
dbEncoding = getattr(connection, "dbEncoding") or "ascii".
2010-01-06 16:01:40 UTC by phd
-
Fixed in the revisions 4067, 4068 (branch 0.12 and the trunk.) Thank you!
2010-01-06 15:48:16 UTC by phd
-
The change to test_picklecol.py.diff is just to a check for blob support, so for no-blob databases, the test is skipped rather than failed.
2010-01-02 20:45:06 UTC by dvkeeney
-
I am submitting 8 diffs (unified diff format) and two new files. The two new files constitute a new package that go with the other database (sub) packages.
The two files are __init__.py and rdbconnection.py.
2010-01-02 20:31:13 UTC by dvkeeney
-
If the DBMS does not have an encoding specified then SQLObject fails in col.py complaining that the 2nd parameter must be a string not None. This situation could easily exist in databases migrated from MySQL 3.x.
The solution seems to be to add a test in the 'from_python' method of StringValidator'. I put it after the call to getattr.
if dbEncoding == None:
dbEncoding = 'ascii'...
2010-01-02 19:12:04 UTC by nobody
-
In the end of makeConnection, in postgres/pg_connection.py, the method 'query' is called on the connection object.
The connection object has just been created using a call to one or another DB API constructors, and the DB API spec does not have a 'query' method. As far as I know, the psycopg2 implementation does not have such a method either.
I patched my copy by adding an hasattr call...
2009-12-31 01:51:06 UTC by dvkeeney
-
Fixed in r4065. Thank you!
2009-12-31 01:36:48 UTC by phd
-
You are right.
backends = backend
is enough. Fixed in the revision 4062, will be in the next round of releases. Thank you!
2009-12-31 01:19:41 UTC by phd
-
The __init__ method of PostgresConnection has this line sequence near the end:
if "charset" in kw:
self.dbEncoding = self.kw["charset"] = kw.pop("charset")
The self.kw attribute does not exist, so if a 'charset' keyword param is provided, the init crashes.
2009-12-31 01:04:03 UTC by dvkeeney
-
When a 'backend' parameter is passed to the PostgresConnection __init__, it is ignored.
from postgres/pgconnection.py :
This first line in __init__,
backends = kw.pop('backend', None) or 'psycopg'
should be like:
backends = backend or 'psycopg'
or just:
backends = backend
since the backend param has a default value of 'psycopg'.
2009-12-31 00:56:27 UTC by dvkeeney
