-
It seems I cannot modify a tracker item that has been closed, so here is a new one that refers to the patch #2925828: add BS1 mac compression in compress_sword1
This patch introduced a memory leak in CompressionTool::encodeAif() as the aifData array was not freed. The patch attached to this item fix the memory leak.
2010-01-04 22:21:06 UTC by criezy
-
Excellent! Committed as is. Thank you!
2010-01-04 21:22:30 UTC by sev
-
Thanks.
2010-01-04 20:58:41 UTC by fingolfin
-
Thanks.
2010-01-04 20:57:24 UTC by fingolfin
-
This patch add support for compressing the mac version of BS1 in compress_sword1. It mainly does two things:
1) Add AIFF encoding to mp3/ogg/flac in the CompressionTool class. I have implemented it in that class in case it is needed by other tools, but if you prefer you can move the encodeAIF() function to the CompressSword1 class instead.
2) When using the mac version (it is detected by...
2010-01-04 20:29:44 UTC by criezy
-
This is a small patch that fix a comment in gui/configuration.h for the tools.
2010-01-04 20:21:41 UTC by criezy
-
This patch fixes two recent issues with the tools:
1) It fixes the name of the executable in the Info.plist file for the ScummVM Tools MacOS X bundle
2) It adds an include of config.h in compress.cpp (since that file is now using defines from configure). Without that change vorbis and flac are never built in.
2010-01-04 20:20:10 UTC by criezy
-
Introducing a private enum for this purpose is indeed a proper solution, and the easiest way to stay backwards compatible.
2010-01-04 14:41:10 UTC by fingolfin
-
I was thinking about something like that, too. It could even be the same list of numbers as now ("for historical reasons"), to avoid breaking the current lure.dat.
2010-01-04 04:48:30 UTC by eriktorbjorn
-
Unless there's any better solution, I can introduce my own enum for the set of supported languages, and use them rather than the main language list. That way the language Ids will remain permanently the same.
2010-01-04 02:11:33 UTC by dreammaster
