Share

GC GreatCode

The forum address has changed, you have been automatically redirected. Please update any bookmarks to use the new URL.

Subscribe

A couple of bug fixes

You are viewing a single message from this topic. View all messages.

  1. 2009-01-01 23:28:12 UTC
    Hi...

    I found a couple of problems and fixed them.
    I used Visual Studio 2008.
    The fixes are small.

    1 - If there are non-ASCII characters in a file, it could cause GC to crash. The fix silently strips non-ASCII characters and continues.

    2 - If you specify a path for finding GC.cfg, it would cause a crash.
    This was because config.c defined the following:

    char *gz_CfgFileName = "GC.cfg";

    This buffer is strlen("GC.cfg") characters long.

    the fix is:

    char gz_CfgFileBfr[MAX_PATH] = "GC.cfg";
    char *gz_CfgFileName = gz_CfgFileBfr;

    also an strcpy is changed to strncpy to avoid a buffer overflow.

    I would like to submit the complete fixes. If interested please contact me at jgluckca@yahoo.ca and use a subject line like "GC fixes" or something similar so I won't think its spam :-)

< Previous | 1 | Next >

Add a Reply

This forum does not allow anonymous participation.

Log in to add a reply. Not registered? Create an account to participate and receive email updates when replies are posted to this topic.