-
I am unable to produce a shorter patch (sorry). Most changes are due to my editor PEP8-fying the code: indenting with 4 spaces, trimming whitespace, and wrapping lines at 80 characters.
The functional changes are in 3 files (attached): library.py, funct_list.py, and FreeImagePy.py.
In library.py, line 133 now reads:
if sys.platform == 'win32' and '64 bit' not in sys.version:
In...
2009-12-16 17:32:13 UTC by cjgohlke
-
First of all, thanks for the patch.
Can you please send me only the "real" diff? I can't found where you modify the sources. A simple method can be to save with windows end line and after modify that source. After you can create the patch, that I think will be smaller than 150k :).
Another method it's to checkout from svn the sources and, from the command line do: svn diff -x...
2009-12-16 07:51:34 UTC by michelepetrazzo
-
The attached patch allows to use FreeImagePy on 64-bit Python for Windows. The patch is rather large due to automatic code reformatting by my editor (sorry). The __ctrlColorUsed function was improved by using a function dictionary lookup instead of iterating through the function list. The test.py and test_old.py scripts now succeed on Python 2.6.4 for Windows 64-bit with FreeImage.dll version...
2009-12-16 03:01:02 UTC by cjgohlke
-
Thanks for the patch. Uploaded into r30.
2009-11-23 07:45:50 UTC by michelepetrazzo
-
michelepetrazzo committed revision 30 to the FreeImagePy SVN repository, changing 1 files.
2009-11-23 07:43:31 UTC by michelepetrazzo
-
The library loading code which alters the path uses windows specific seperators, and under specific conditions (depending on the order of the existing path) can cause the library to be unloadable on UNIX. Patch is attached which only uses ';' on windows platforms.
2009-11-20 20:07:03 UTC by john_krukoff
-
> I don't think the minisblack check in convertToMinIsWhite is important
Yes that it's important! If the image aren't minisblack, the converter method cannot transfor to miniswhite!
A try that I just make:
michele@portatile:~/tmp$ ls
in.tif test_tiff_bw.py
michele@portatile:~/tmp$ tiffinfo in.tif |grep Photo
Photometric Interpretation: min-is-black
michele@portatile:~/tmp$ cat...
2009-10-26 08:40:50 UTC by michelepetrazzo
-
I don't think the minisblack check in convertToMinIsWhite is important, as I've checked and the images are all minisblack before the conversion. Unfortunately, I can't just do the other conversions first, as I have a database of images already previously converted to miniswhite that I'm trying to resize, and this bug is rendering FreeImagePy unusable for working with those.
2009-10-24 15:18:18 UTC by john_krukoff
-
Seeing my code there is there a control before do the conversion. the image must be minisblack (freeimagepy.py line 1588) and if isn't, I silently return. Ok, can be a right modify to return 1, for example, if there is an error, but for now you can control the image before pass it to convertToMinIsWhite
Michele.
2009-10-23 15:24:13 UTC by michelepetrazzo
-
After calling convertToMinIsWhite on an image, image altering functions silently fail. I've tested with MakeThumbnail and Rescale, and both return an all zeros image when called on an image altered by convertToMinIsWhite. By all zeros I mean that the BPP is 0, the width and height are 0, everything appears to be 0, regardless of what the image was before the call to MakeThumbnail or Rescale...
2009-10-22 23:15:12 UTC by john_krukoff
