-
Line 1302 contains an extra & that triggers a PHP error.
2009-07-27 23:15:11 UTC by markrose
-
I am attaching a new version of my patch. The old one could deadlock under certain circumstances under new PHP versions because the behavior of fread() has changed. With the new PHP behavior fread() will wait until it has read the number of bytes you wanted to read.
This new patch solves this by using fgets() instead of fread().
2009-06-18 19:48:09 UTC by nobody
-
I have reimplemented safe_read_message to fix various bugs. The original function does a busy-read on a non-blocking socket. Even though the implementation tries to usleep() in between it is still a busy loop. It manages to eat 80% CPU on my AMD quad-core just waiting for reserve() to return a job.
This new implementation preserves the features of the original and fixes a couple of other bugs.
2009-06-02 11:19:56 UTC by sander_marechal
-
icyliquid committed revision 13 to the A PHP beanstalkd Client SVN repository, changing 1 files.
2009-04-14 18:47:43 UTC by icyliquid
-
icyliquid committed revision 12 to the A PHP beanstalkd Client SVN repository, changing 1 files.
2009-04-14 18:24:36 UTC by icyliquid
-
A very lazy temporary bug fix would be the following:
public function reserve_with_timeout($in_timeout=0)
{
if (BeanStalk::DEBUG) echo __METHOD__."\n";
$this->safe_send_message("reserve-with-timeout {$in_timeout}");
$real = $this->safe_read_message();
$res = $this->check_reply($real, array(
'/RESERVED (\d+) (\d+)/' => self::OPERATION_OK,
2009-04-03 23:28:43 UTC by nobody
-
By definition the reserve command should read data for a length of as returned by the command. However due to a bug if the portion of the result contains one or more \r\n's the resulting payload is incorrect and the buffer is never fully read. The put() function however handles this correctly.
2009-04-03 23:21:50 UTC by nobody
-
icyliquid committed revision 11 to the A PHP beanstalkd Client SVN repository, changing 1 files.
2009-03-26 17:10:06 UTC by icyliquid
-
Ups. Initial patch was reversed attaching proper one now.
2009-03-23 12:57:41 UTC by zlender
-
There is a php notice in BeanStalk.class.php notice: Only variable references should be returned by reference in /home/rzlender/npscan/www/sites/all/modules/custom/np_potpourri/BeanStalk.class.php on line 292. Attached patch fixes it.
2009-03-23 10:26:58 UTC by zlender
