#68 fix build.xml cobertura test harness

3.0.0
closed-fixed
Benjamin Reed
None
5
2008-06-06
2008-05-14
Patrick Hunt
No

Need to fail if the junit tests fail - missing fail is causing build to be successful even if cobertura fails.
(ci is running cobertura and not std test target)

Discussion

  • Patrick Hunt
    Patrick Hunt
    2008-05-14

    patch build.xml to fix cobertura test runner

     
  • Patrick Hunt
    Patrick Hunt
    2008-05-16

    Logged In: YES
    user_id=12853
    Originator: YES

    Ben please merge this asap to address ci issue. Thanks.

     
  • Benjamin Reed
    Benjamin Reed
    2008-05-20

    Logged In: YES
    user_id=154690
    Originator: NO

    Is this really enough? It will still show up as unstable build if there are error messages printed even though it returns successfully. Right?

     
  • Patrick Hunt
    Patrick Hunt
    2008-06-06

    Logged In: YES
    user_id=12853
    Originator: YES

    If the tests pass the build will be successful. If a test fails (throws exception or assertX fails) then build will be unsuccessful. This is regardless of println/logging output. Hudson actually parses the output looking for errors (even if build is listed as successful) - if build is successful but there are failure type messages in the stdout/log then it will list the build as unstable, otw will list as success/failure appropriately.

    I tested the failure case Nigel was seeing and it addressed the issue.

     
  • Benjamin Reed
    Benjamin Reed
    2008-06-06

    Logged In: YES
    user_id=154690
    Originator: NO

    great. I'll commit then.

     
  • Benjamin Reed
    Benjamin Reed
    2008-06-06

    Logged In: YES
    user_id=154690
    Originator: NO

    Committed revision 175.

     
  • Benjamin Reed
    Benjamin Reed
    2008-06-06

    • status: open --> closed-fixed