#12 NPE during normal operations

3.0.0
closed
Mahadev Konar
None
5
2008-06-10
2008-04-20
Ted Dunning
No

Somehow, I got my server to do this evil thing. I will try to figure out how to do this more consistently.

4/19/08 5:30:31 PM PDT [FinalRequestProcessor.java@220][8]: ****************************** 11944c2037100d8 256 fffffffffffffffe txn type = unknown getChildren n/a
4/19/08 5:30:31 PM PDT [FinalRequestProcessor.java@227][8]: ffffffff0
4/19/08 5:30:31 PM PDT [FinalRequestProcessor.java@228][8]: : java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.hash(ConcurrentHashMap.java:157)
at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:730)
at com.yahoo.zookeeper.server.DataTree.getNode(DataTree.java:84)
at com.yahoo.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:205)
at com.yahoo.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:226)
at com.yahoo.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)

4/19/08 5:30:49 PM PDT [FinalRequestProcessor.java@220][8]: ****************************** 11944c2037100d8 257 fffffffffffffffe txn type = unknown exists n/a
4/19/08 5:30:49 PM PDT [FinalRequestProcessor.java@227][8]: ffffffff0
4/19/08 5:30:49 PM PDT [FinalRequestProcessor.java@228][8]: : java.lang.NullPointerException
at com.yahoo.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:169)
at com.yahoo.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:226)
at com.yahoo.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:113)

Discussion

1 2 > >> (Page 1 of 2)
  • Benjamin Reed
    Benjamin Reed
    2008-04-21

    Logged In: YES
    user_id=154690
    Originator: NO

    Which version of Java are you using?

     
  • Ted Dunning
    Ted Dunning
    2008-04-21

    Logged In: YES
    user_id=972206
    Originator: YES

    java version "1.5.0_13"
    Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_13-b05-241)
    Java HotSpot(TM) Client VM (build 1.5.0_13-121, mixed mode, sharing)

    Running on a mac under OSX 10.4

    I think actually that this is actually a case of invalid arguments (from me) causing an obscure message rather than being caught. My suspicion is null path passed to create. I still owe you a test case.

     
  • Benjamin Reed
    Benjamin Reed
    2008-04-22

    Logged In: YES
    user_id=154690
    Originator: NO

    I think your suspicion is correct. (I thought we were handling this.) It's actually a double bug! Both the server and client should check for a null path.

     
  • Ted Dunning
    Ted Dunning
    2008-04-22

    Logged In: YES
    user_id=972206
    Originator: YES

    Good thing then to have found it.

    My only problem is that by inspection, my code "can't" be sending the null. The usual software engineering definition of "can't" is obviously the one that I mean here.

     
  • Patrick Hunt
    Patrick Hunt
    2008-05-05

    Logged In: YES
    user_id=12853
    Originator: NO

    Ben looks like you had a handle on this. Please submit a patch.

     
  • Patrick Hunt
    Patrick Hunt
    2008-05-05

    • assigned_to: nobody --> breed
     
  • Benjamin Reed
    Benjamin Reed
    2008-05-12

    • milestone: --> 3.0.0
    • assigned_to: breed --> mahadevkonar
     
  • Mahadev Konar
    Mahadev Konar
    2008-05-30

    Logged In: YES
    user_id=1926680
    Originator: NO

    Ted,
    just want to check if null path is the only problem here. In your comments you mentioned that null path might not be possible. Can you check to see if this is true -- (in a QA sense -- not a programmer sense)? :)

     
  • Ted Dunning
    Ted Dunning
    2008-05-30

    Logged In: YES
    user_id=972206
    Originator: YES

    I am pretty sure that I had a null even though it was impossible (in the programming sense).

    I haven't had this problem since then.

     
1 2 > >> (Page 1 of 2)