#33 Unable to remove user from fixed partyline channel

closed-fixed
Psychon
Modules (21)
6
2007-08-06
2007-07-29
No

I'm unable to remove users from fixed channels. Running svn-version 816.

<juKay> list
<*partyline> +-------------------+-------+
<*partyline> | Channel | Users |
<*partyline> +-------------------+-------+
<*partyline> | ~#testing | 1 |
<*partyline> +-------------------+-------+

<juKay> ListFixUsers ~#testing
<*partyline> user1

<juKay> DelFixChan user1 ~#testing
<*partyline> user1 is not in ~#testing or isnt fixed to it

Discussion



  • 2007-07-29

    • summary: Unable to remove user from fixed channel --> Unable to remove user from fixed party channel
     


  • 2007-07-29

    • summary: Unable to remove user from fixed party channel --> Unable to remove user from fixed partyline channel
     


  • 2007-07-29

    Logged In: YES
    user_id=415825
    Originator: YES

    To lazy to put a patch togeather and upload.

    Change line 452 in partyline.cpp from:
    if(!pChan || pChan->IsFixedChan(sUser)) {

    to
    if(!pChan || !pChan->IsFixedChan(sUser)) {

     
  • Logged In: NO

    the problem you described in 1762981 (channels not removed after bnc restart) is due to

    CString sFixed = GetNV(sUser);
    sFixed.Replace("," + sChan, "");
    SetNV(sUser, sChan);

    the channel is being removed from sFixed but sChan is being written to file
    changing
    SetNV(sUser, sChan);
    to
    SetNV(sUser, sFixed);
    does fix it but there's a problem with
    sFixed.Replace("," + sChan, "");

    you get unexpected results if you add
    ~#testing and ~#testing2 and then remove ~#testing
    so this part needs to be reworked too

     
  • Psychon
    Psychon
    2007-08-04

    • priority: 5 --> 6
    • assigned_to: prozacx --> psychon
     
  • Psychon
    Psychon
    2007-08-04

    Logged In: YES
    user_id=1654410
    Originator: NO

    Ill take a look at this later.

    I guess I broke quite some stuff with my partly partyline rewrite. :(

    psychon

     
  • Psychon
    Psychon
    2007-08-06

    • status: open --> closed-fixed
     
  • Psychon
    Psychon
    2007-08-06

    Logged In: YES
    user_id=1654410
    Originator: NO

    Fixed in rev 818, thanks for the patch.

    I will change the saving of fixed chans, dont know yet exactly how.