#10 lower floor for ADSR envelopes

Done
closed
Will Godfrey
None
5
2015-06-15
2013-05-13
James Mckernon
No

I notice that when a long envelope is used for attack or decay, the sound starts (or ends) rather suddenly, at a level quite above the threshold of audibility. For example, a note with a long decay tail will noticeably stop suddenly, rather than fading away to inaudibility. It would be great if the note started and stopped at a much quieter level, so their beginning and end couldn't be so distinctly heard. (I'm no expert, but I have used -60db-80db for this, i.e. a multiplier of 0.001 - 0.0001, and that seems to be enough.)

Discussion

  • James Mckernon
    James Mckernon
    2013-05-19

    On inspection, this turned out to be a simpler fix than I expected: there's a #define for MIN_ENVELOPE_DB in src/Synth/Envelope, which I have now tweaked in my local copy. Hence, don't feel obliged to make any changes to the repository on my behalf (although I suppose that it's possible that others might appreciate this change.) Thanks.

     
  • Will Godfrey
    Will Godfrey
    2014-03-16

    • status: open --> accepted
    • assigned_to: Will Godfrey
    • Group: --> Next Release (example)
     
  • Will Godfrey
    Will Godfrey
    2014-03-16

    This is set to -40 by default, which is the same as Zyn. What setting do you have? Have you noticed it impacting other areas?

     
  • James Mckernon
    James Mckernon
    2014-03-22

    Hi Will; thanks for looking at this. I've set it to -60dB for my own use. The issue with -40 isn't noticeable very often - only when using patches with a very long decay, and when the end of the decay is 'exposed', that is, there isn't much other noise happening at the same time as the envelope finishes.

     
  • Will Godfrey
    Will Godfrey
    2014-03-22

    My concern is that a lower level will result in 'wasted' processor cycles and effectively lower poyphony i.e. fewer notes aparently being active at any one time.

    A possible compromise would be to make MIN_ENVELOPE_DB a runtime setting with hard limits at (say) 30 and 80. This would not be very difficult, but I will have to look at it more closely and see if there is any interest in it from others on the yoshimi list.

     
  • James Mckernon
    James Mckernon
    2014-03-22

    Yes, I understand the drawbacks. Making it a runtime option seems reasonable, though on the other hand, that might be overkill. Whatever you think is reasonable....

     
  • Will Godfrey
    Will Godfrey
    2014-05-26

    • Group: Next Release (example) --> Considered
     
  • Will Godfrey
    Will Godfrey
    2014-10-02

    Version 1.2.4 now has -60dB as the default.

     
  • Will Godfrey
    Will Godfrey
    2014-10-02

    • status: accepted --> closed
     
  • Will Godfrey
    Will Godfrey
    2015-06-15

    • Group: Considered --> Done