Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#9 Custom Server Vars Filtering

open
nobody
None
5
2007-04-21
2007-04-21
fate swarm
No

This patch adds custom server info variables filtering as shown on http://www.forums.urbanterror.net/index.php/topic,7710.0.html

Discussion

  • fate swarm
    fate swarm
    2007-04-21

    Logged In: YES
    user_id=382467
    Originator: YES

    File Added: xqf-custom_filtering+comma_separated.patch

     
  • fate swarm
    fate swarm
    2007-04-21

    Logged In: YES
    user_id=382467
    Originator: YES

    updated the patch with comma separated values support as described in http://www.forums.urbanterror.net/index.php/topic,7710.0.html

     
  • fate swarm
    fate swarm
    2007-04-21

    Logged In: YES
    user_id=382467
    Originator: YES

    I should add, this patch is unrelated to urban terror 4 and 'battleye' patches submitted here, it does not include them (as they are in that forum thread).

     
  • fate swarm
    fate swarm
    2007-04-21

    Logged In: YES
    user_id=382467
    Originator: YES

    File Added: xqf-1.0.5-custom_filtering-2.patch

     
  • fate swarm
    fate swarm
    2007-04-23

    patch adding filtering based on a list of server info variables added by the user. + comma separated values support.

     
  • fate swarm
    fate swarm
    2007-04-23

    Logged In: YES
    user_id=382467
    Originator: YES

    File Added: xqf-1.0.5-custom_filtering-3.patch

     
  • Ludwig Nussel
    Ludwig Nussel
    2007-04-25

    Logged In: YES
    user_id=333900
    Originator: NO

    A proper implementation of more versatile server filters are on my withlist since a long time. Your patch is a step it the right direction but it's still not powerful enough IMO. Support for comparative operators (<,>,==,...) would be highly useful for example. But then you also want bit operators (&,|,>>,<<,...) e.g. for matching dmflags bits.

    Wrt implementation itself. You should separate terms with '&&' instead of '||' because '&&' means 'and' and you also actually link them as 'and' internally. That allows to implement 'or' as well sometime. Also you use g_strsplit in a loop ie malloc and free. That's inefficient and slow, you need to already parse the expression into a form that can quickly be processed by the machine when you read the config file.

    btw I prefer to discuss patches on the mailinglist. The sf interface just plain sucks. Please subscribe to the devel list if I didn't already scare you away and you are still interested in xqf development.