Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#254 No warning on exit shown about running script

v1.2.*
closed
nobody
import (29)
v1.2.*
2014-02-17
2013-11-14
Anonymous
No

I started the script to update the search from the maintenance page, the script to update categories from the import page. After the search script had finished and - accoring to the log - while the category script was still running, I closed XOWA. No warning was shown. --Schnark

Discussion

  • gnosygnu
    gnosygnu
    2013-11-15

    • labels: --> import
    • status: new --> queued
    • Expected release: --> v0.12.*
     
  • gnosygnu
    gnosygnu
    2013-11-15

    Thanks for the detail.

    This is admittedly an issue. I realized that a user might run multiple simultaneous tasks, but always hoped the user would not. It's one of the reasons why I exposed the script. The user could execute tasks serially in one session, rather than try to execute them in parallel. If anything, serial is more performant (parallel would probably lead to a lot of disk thrashing)

    I'd have to fix this by implementing a true queue system. Right now, each import / maintenance task launches its own independent thread. The bug you're seeing is a result of one thread telling the app "all clear", even though the other thread is still running.

    I'll look at doing this for a v0.12.* release, but it's going to require some redesign. I have been delaying it, but it needs to be done

     
  • gnosygnu
    gnosygnu
    2013-12-31

    • Expected release: v0.12. --> v1.1.
    • Milestone: PFE --> v1.1.*
     
  • gnosygnu
    gnosygnu
    2013-12-31

    I looked at this earlier, and the behavior is very strange. I think it's SWT related, but haven't had time to track it down. I'll review again in a 1.1 release

    EDIT: Comment in wrong thread. Should have gone into warnings about options

     
    Last edit: gnosygnu 2014-02-03
  • gnosygnu
    gnosygnu
    2014-02-03

    • Expected release: v1.1. --> v1.2.
    • Milestone: v1.1. --> v1.2.
     
  • gnosygnu
    gnosygnu
    2014-02-03

    I'm moving this to v1.2, though it will probably end up in v1.3, as it requires a bit of time to redesign the existing framework.

     
  • gnosygnu
    gnosygnu
    2014-02-12

    I decided to do a simpler approach and prevent the user from running multiple items at once. If the user tries to submit a 2nd import task, the following message box appears

    An import is in progress. Please wait for it to complete. If you want to do multiple imports at once, see Help:Import/Script.
    

    In your case, you should combine the generated script from both pages and run it on one page.

    I'll implement a true queue later, but I'm hoping this will suffice for now.

     


Anonymous


Cancel   Add attachments