#77 remove generated files from repository

Unstable_(example)
closed
nobody
None
5
2014-06-30
2013-05-16
Adam Dingle
No

The Xournal git repository contains a few .c and .h files generated by Glade. Checking in generated files is bad practice for many reasons. Here's a patch to remove them.

1 Attachments

Discussion

  • Adam Dingle
    Adam Dingle
    2013-05-16

    Whoops - it turns out that without these files the build breaks since there is no automated rule to generate these files from the .glade file (and in fact it doesn't seem possible to tell Glade to do that from the command, so I see no way to add such a rule). Never mind. :)

     
  • Denis Auroux
    Denis Auroux
    2013-05-16

    There is a way to autogenerate: glade-2 -w xournal.glade
    But glade-2 is buggy and on its way to deprecation, so that it's not a
    viable option for everyone, and I strongly feel in this instance it's
    better to keep the autogenerated files in the codebase. (More often than
    not, on my system "glade-2 -w" ends with a crash, even though so far for
    me it seems to generate the files just fine before crashing).

    (Also, one minor reason to do so: patches generated against the .glade
    file tend to be huge and unreadable unless the .glade file is edited by
    a human rather than by glade-2 -- the .glade file contains lots of
    useless timestamps and the like that make patches just unwieldy; the
    part of the patch that concerns the autogenerated .c code is usually the
    only way to figure out what exactly the patch accomplishes and how.)

    Denis

     
  • Adam Dingle
    Adam Dingle
    2013-05-16

    OK, thanks for the explanation - this is helpful.

     
  • Denis Auroux
    Denis Auroux
    2014-06-30

    • status: open --> closed