#59 Confirm close dialog focus fix

closed-accepted
nobody
None
5
2014-08-16
2010-10-15
Kit Barnes
No

Previously the confirm close dialog for a modified document would focus the "No" button by default, this patch focuses the "Save" button and re-labels+moves the controls to comply with the gnome HIG.

Fixes this bug:
https://sourceforge.net/tracker/?func=detail&aid=3073507&group_id=163434&atid=827733

Discussion

  • Denis Auroux
    Denis Auroux
    2010-10-15

    Thanks! (By the way, I've been trying to reply to an e-mail you sent me recently, but your @sourceforge.net address bounces. Please contact me by regular e-mail -- my address = my username @ math.mit.edu)

    Denis

     
  • Denis Auroux
    Denis Auroux
    2010-10-18

    Patch included in CVS. I've kept the current order of the controls though, I find the Gnome guidelines counterproductive on this particular issue.

    Denis

     
  • Kit Barnes
    Kit Barnes
    2010-11-09

    • status: open --> open-accepted
     
  • Denis Auroux
    Denis Auroux
    2012-05-23

    Included in 0.4.6, along with a small change for backward compatibility with GTK+ 2.10 (#define GTK_STOCK_DISCARD to mean GTK_STOCK_NO if it is undefined.)

    Denis

     
  • Denis Auroux
    Denis Auroux
    2012-05-23

    • status: open-accepted --> closed-accepted