Re: [Xournal-devel] image patch revised and included in CVS

[dmg <dm...@uv...>]

Hi Denis,

it would really great if you switched to git. it would be way easier
for us to integrate your changes (and for you to integrate ours).

--daniel

On Thu, Jun 28, 2012 at 3:58 PM, Denis Auroux <au...@ma...> wrote:
> Dear all,
>
> Simon Guest's enhanced image patch has been finally reviewed, cleaned up,
> and incorporated into the xournal CVS repository.
>
> If you have time and interest, please test thoroughly the CVS version, as
> the code of the patch has been modified significantly. In particular, the
> code to rescale and display at different zoom levels has been simplified
> considerably, and the images now look better on my system (Fedora 16), but
> I'd be interested in confirmation that this is also the case for everyone.
>
> User-visible changes, besides the invisible code cleanup under the hood:
>
> - a just-inserted image can now be copy-pasted (cut/copy were disabled);
> - "busy" cursor when compressing an image to the clipboard upon cut/copy,
>   since it can be a lengthy operation;
> - image rescaling is left up to gnomecanvas, which does a better job than
>   the code in the existing patch (at least on my system, things look much
>   crisper that way);
> - it's now possible to map button 2 or 3 to the image tool.
>
> Next to do items for me in relation to this patch (in the coming days):
>
> - paste and selection resize mistakenly re-stack the selected items on top
>   of the selection rectangle;
> - for the select tool, clicking in an image should select it (as with text
>   zones)
> - there should be an option for the image mode to revert to the previous
> tool
>   (so that the "image" tool acts as a one-time command rather than a tool)
> - should be able to directly paste text into xournal, same as images,
>   without having to first create a text zone.
>
> (I know how to do all of these and will do them soon, no help needed.)
>
> Please let me know if you notice any regression compared to the existing
> image patch.
>
> Thanks!
> Denis
>
> --
> Denis Auroux                             au...@ma...
> University of California, Berkeley       Tel: 510-642-4367
> Department of Mathematics                Fax: 510-642-8204
> 817 Evans Hall # 3840
> Berkeley, CA 94720-3840
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Xournal-devel mailing list
> Xou...@li...
> https://lists.sourceforge.net/lists/listinfo/xournal-devel
>



-- 
--dmg

---
Daniel M. German
http://turingmachine.org