#16 Bug in delegate signature checking

0.9
closed-fixed
minahito
None
7
2008-11-20
2008-11-05
K.Ono
No

I dont use the signature checking feature in delegate manager, but I think this is a bug and will not work for string type checking?

On line 325 in core/XCube_Delegate.class.php

-----------------
case "string":
if (!empty($args[$i]) && is_string($args[$i])) {
return false;
}
break;
-----------------

I guess this should be like below?

-----------------
case "string":
if (!empty($args[$i]) && !is_string($args[$i])) {
return false;
}
break;
-----------------

Discussion

  • minahito
    minahito
    2008-11-07

    • priority: 5 --> 7
    • status: open --> open-accepted
     
  • minahito
    minahito
    2008-11-16

    • labels: 963736 -->
    • milestone: 890230 -->
     
  • minahito
    minahito
    2008-11-16

    • milestone: --> 0.9
    • assigned_to: nobody --> minahito
     
  • minahito
    minahito
    2008-11-20

    Thank you for your patch. I had fixed this, but I forgot that I closed this item.

     
  • minahito
    minahito
    2008-11-20

    • status: open-accepted --> closed-fixed