#36 banners.php XHMTL 1.0 Trans validation

Patches
closed
Jan Pedersen
5
2012-09-25
2004-05-18
Herko Coomans
No

banner.php creates invalid XHTML 1.0 Transitional
output when displaying Flash banners.

in banners.php, change lines 127 - 129 to:

echo "<param name="\\"movie\\"" value="\\"$imageurl\\""/>";
echo "<param name="\\"quality\\"" value="\\"high\\""/>";
echo "<embed src="\\"$imageurl\\"" quality="\\"high\\"" pluginspage="\\"http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash\\";" type="\\"application/x-shockwave-flash\\"" width="\\"468\\"" height="\\"60\\"">";

(changes are that param tags are closed with /> and
that all variable values are enclosed in \" \" 's)

Discussion

  • Herko Coomans
    Herko Coomans
    2004-05-18

    Logged In: YES
    user_id=441189

    Sorry, missed one error (; in attributions list), so lines
    126 - 131 should be:

    echo "<object classid="\\"clsid:D27CDB6E-AE6D-11cf-96B8-444553540000\\"" codebase="\\"http://download.macromedia.com/pub/shockwave/cabs/flash/" swflash.cab#version="6,0,40,0\\";" width="\\"468\\"" height="\\"60\\"">";
    echo "<param name="\\"movie\\"" value="\\"$imageurl\\""/>";
    echo "<param name="\\"quality\\"" value="\\"high\\""/>";
    echo "<embed src="\\"$imageurl\\"" quality="\\"high\\"" pluginspage="\\"http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash\\"" type="\\"application/x-shockwave-flash\\"" width="\\"468\\"" height="\\"60\\"">";
    echo "</embed>";
    echo "</object>";

     
  • Jan Pedersen
    Jan Pedersen
    2004-12-26

    Logged In: YES
    user_id=841117

    Fixed in CVS and waiting for review before merging to the trunk.