#1281 Bugs recurring in grouppermform.php

XOOPS_2.5.x
pending
None
1
2013-12-28
2013-06-05
TXMod Xoops
No

As I have already pointed out in the discussion forum, http://xoops.org/modules/newbb/viewtopic.php?post_id=353940

I want to report a bug that occurs if you use a simple code in the file admin/permissions.php.

I think this code should be changed in the core to avoid further burdening all modules that make use of the permissions.

I think that for the next version 2.5.7 you should consider this hack.

In the discussion zispec suggests to initialize the array, but the problem remains for _optionTree even if you initialize with var $_optionTree = array();

Tested on xoops 2.5.5 and 2.5.6

I tried to comment in the file admin/permissions.php of module news, part of code that does not affect the function XoopsGroupPermForm ($title, $modid, $permname, $permdesc, $url ='', $anonymous = true), and the problem is in the code of the class.

Trabis has solved the problem in its module publisher, but I noticed that there is so much code that could be initialized in the class and not written for each module.

We can always avoid rewriting the same code for all modules?

Discussion

    • status: open --> pending
    • assigned_to: Richard Griffith
     
  • While I do wonder why a program would try to render an empty permission form, I do agree with zyspec that using non-initialized values is wrong. Suggested changes applied.