From: Alistair G. <akg...@gm...> - 2015-01-12 18:48:49
|
On Mon, Jan 12, 2015 at 8:50 AM, <hon...@gm...> wrote: > On Sun, 11 Jan 2015 19:52:08 +0100, Alistair Grant wrote: > >> Thanks for your reply, and good point. I'm not even sure how >> tv_grab_huro is being used by various applications. >> >> How about adding this as an option to tv_sort that is disabled by >> default, with help text that it is useful for the XmltvValidation >> tests? > > > I think you can get sorted order from tv_grab_huro simply by changing line 743 to > > foreach (sort keys %CATMAP) { > > The categories in the xml should then always be consistent (rather than being indeterminate). OK, I've made the changes as suggested above and successfully ran tv_validate_grabber a couple of times (once with the supplied test.conf and once with my production configuration). As before, the code can be viewed at: * https://github.com/akgrant43/XMLTV/blob/huro_retry/grab/huro/tv_grab_huro.in The patch can be viewed with: * https://github.com/akgrant43/XMLTV/commit/44d53215ddb6865ff85e533c8fd7049db7958221#diff-0430f28879ec294f84b1cf139b10ad96 The file also contains the modifications for the retry, which are still a work-in-progress. Please let me know what you think (about the category sorting). Thanks, Alistair |