#485 Match not found when there's also a video game

none
closed-fixed
Nick Morrott
tv_imdb (6)
5
2014-04-07
2013-04-26
Anonymous
No

I just started using tv_imdb and its pretty awesome thank you but I hit a bug. I thought I'd try and track it down as my way of saying thank you :)

I noticed that 'Toy Story' and 'Toy Story 2' were on and it found a match for the former but not the latter. I think the problem is that there's a video game of the movie for Toy Story 2 released the same year and they happened to be in the order such that the video game overwrote the movie. It subsequently skipped the video game and found no matches.

-bash-4.2$ grep "Toy Story 2" moviedb.idx
toy%20story%202%20%281999%29 Toy Story 2 (1999) 1999 video_game 0873201

A simple fix might be to filter out video games when building the index in the first place and anything else that's going to be ignored.

Discussion


  • Anonymous
    2013-04-26

    I've not tried this but presumably where it does this

    $qualifier="video_game";

    it could instead just do "next;".

     

  • Anonymous
    2013-04-26

    Maybe some context would help I'm looking at XMLTV/IMDB.pm :)

     

  • Anonymous
    2013-04-26

    Another example is "Van Helsing (2004)".

     
  • Nick Morrott
    Nick Morrott
    2013-05-06

    I've updated IMDB.pm to ignore video games when creating the tv_imdb index. I've tested locally with a freshly-generated index against "Toy Story 2 (1999)" and "Van Helsing (2004)" and both movies now receive a perfect match.

    Please could you update from CVS, regenerate the index, test against your XMLTV data and report back on how things go.

     
  • Nick Morrott
    Nick Morrott
    2013-05-06

    • assigned_to: jveldhuis --> knowledgejunkie
    • status: open --> open-accepted
     
  • Jerry Veldhuis
    Jerry Veldhuis
    2013-12-15

    code fix looks good to me. I've tested. Marking fixed.

     
  • Jerry Veldhuis
    Jerry Veldhuis
    2013-12-15

    • status: open-accepted --> closed-fixed
    • Group: --> v1.0 (example)