#318 Pass FunctionRequest to convertResultImpl method in CC

open
nobody
None
2
2010-04-17
2010-04-08
Ernst de Haan
No

The (Custom)CallingConvention class contains a convertResultImpl method that gets the FunctionResult, the HTTP request and the HTTP response, but does not get the original XINS FunctionRequest object. However, in one of my projects I need the FunctionRequest. It would be more consistent to also pass the XINS FunctionResult.

I will provide a proposed implementation.

Discussion

  • Ernst de Haan
    Ernst de Haan
    2010-04-08

    • priority: 5 --> 6
     
  • Ernst de Haan
    Ernst de Haan
    2010-04-08

    Note that the proposed implementation will keep the old method for backwards compatibility. So existing calling conventions will continue to work unchanged.

     
  • Ernst de Haan
    Ernst de Haan
    2010-04-08

    Proposed implementation is attached to RFE 2984087.

    @Anthony: Can you review?

     
  • Ernst de Haan
    Ernst de Haan
    2010-04-08

    • assigned_to: nobody --> agoubard
     
    • priority: 6 --> 3
     
    • priority: 3 --> 2
    • assigned_to: agoubard --> nobody
     
  • Note that the FunctionRequest or any other useful information (function name, query parameters only needed for the result, client ip, ...) can be passed using the httpRequest.setAttribute()
    This allows more flexibility than just passing the FunctionRequest.