Re: [xine-devel] 0.4.0alpha is in CVS

[Rich W. <rj...@ca...>]

On Tuesday 13 February 2001  1:48 pm, you wrote:
> Hi Rich,
>
> On Mon, 12 Feb 2001, Rich Wareham wrote:
> > On Monday 12 February 2001  4:13 am, you wrote:
> > > - spu decoder: yes, it was me, I broke it - sorry folks!
> > >   I didn't want to wait any longer with my commit, so I checked it in
> > >   as it is.
> >
> > Well fixed it. Take a look below. Comments? If its OK with everyone, I'll
> > check it in tommorrow morning.
>
> looks very clean to me :-)
>
> erm, that
>
> > printf ("xine_init: video thread created\n");
>
> is a bit misleading, "spu thread created" would be better instead.

Yeah. I noticed that when I was merging. Fixed now.

>
> Apart from that I'm impressed how fast you adapted the SPU stuff to the
> new architecture (!)

np

[snip]

> The next step would be to make the subtitles work in xshm as well - this
> would require to move the subtitle decoding from display to decoding time
> so the subtitle overlay could be copied to the rgb buffer during the
> yuv2rgb conversion.

From the POV of video_out, it doesn't care when the decoding is done, jsut 
that the buffers overlay_image and mask_image contain the correct subtitle 
images in the correct format. As it is, the SPU decoder can only decode to 
YUV (although RGB shouldn't be /that/ hard). It would be better to overlay 
onto the image before conversion but when I tried that I couldn't find any 
way of detecting if the video decoder had finished with the image (i.e. bits 
of subtitle kept wandering around due to motion compensation :)). Does the 
new architecture help this?

-- 
==================================================================
Rich Wareham <rj...@ca...>
Robinson College, Cambridge, CB3 9AN

Go to a movie tonight.  Darkness becomes you.
==================================================================