[xine-devel] [xine-lib-1.2] progressive frame detection regression in vdpau_h264.c

[Lucian M. <lu...@us...>]

Hi there,

I'm using xine-lib-1.2 from
http://hg.debian.org/hg/xine-lib/xine-lib-1.2 as HDTV decoder on VDPAU
hardware in conjunction with VDR, and I'm receiving both 720p and 1080i
HD channels. In the VDR community, the folks using VDPAU with xine-lib
recommend setting video.output.vdpau_honor_progressive:1 especially when
the VDPAU hardware is on-board and one is receiving a lot of 720p
material, to save GPU power.

Well, that worked well, I was even happily watching the Football/Soccer
WC 2010 from South Africa both on 720p and 1080i channels, the latter
where deinterlaced properly (temporal at that time, with my IGP GeForce
8300). My system is Gentoo, so I'm installing xine-lib-1.2 from an
ebuild which pulls the latest version every time, and I had to update
few weeks ago because of some VDPAU extension patches used for VDR (like
those here if it matters
http://durchflieger.dachsweb.de/vdpau-extensions/v13/ ), anyway, after
the update, some 1080i channels are detected as having progressive frame
and hence no longer deinterlaced if configuring
video.output.vdpau_honor_progressive:1. At least they are deinterlaced
when commenting that setting out or explicitly make it 0.
This all has nothing to do with the VDR-specific patches I mentioned
above, as I also tried without them and luckily saw the printf in line
15 on my console "progressive:1" (
http://hg.debian.org/hg/xine-lib/xine-lib-1.2/diff/c52e8f96600b/src/video_dec/libvdpau/vdpau_h264.c
). So that detection is wrong, that can be easily reproduced when
playing a 1080i TS file chunk I could provide, if you specify some
upload location, with plain xine, some verbosity and the "honor
progressive" flag set to 1.

Cheers,
Lucian