Re: [xine-devel] PATCH : xine-ui save and auto load post plugin chains - final

[Hans-Dieter K. <hd...@t-...>]

Hi Marcel,

Marcel Janssen wrote:
> On Tuesday 06 December 2005 00:39, Hans-Dieter Kosch wrote:
> 
>>Great work. Sorry for the late answer. I hope I'll find time in the near
>>future to review and implement it. It touches some files I'm currently
>>also working on and I'd like to coordinate it all.
> 
> 
> 
> I found a small issue 2 days ago. If a filter that has no parameters, xine 
> will crash when the save button is clicked. This should be easy to solve as 
> it's caused by me assuming that all filters have parameters. It should be 
> solved within the save function. I'll try to find some time for it this 
> weekend to make the patch work correctly. I found the bug when I tried to use 
> the fill filter (which I normally never use and therefore didn't check).
> For other filters it works well and since I use it on a daily basis I can 
> state it's stable.
> 
OK. No hurry. Continue to test and optimize, then send a new patch. I 
think I'll find no time in the next weeks to keep busy with it anyway. 
Please match your patch finally against latest CVS at the time you post it.

Cheers,
Hans-Dieter