From: Miguel Freitas <mfreitas@gm...> - 2005-07-01 13:25:44
On 6/24/05, Diego 'Flameeyes' Petten=F2 <flameeyes@...> wrote:
> The big attached patch make use of the standard defines instead of ARCH_*=
> Also, I've fixed a couple of places where a check for x86 could have been=
> x86 and x86_64.
thanks for your efforts cleaning up these macros, but unfortunately i
believe we should not apply this patch the way it is. i have not
researched about the roots of ARCH_* and the standard defines, but one
thing i know is that ARCH_ became the de facto standard in several
projects. as you might have noted, much (most?) of your patch refer to
other projects we share code (libmpeg2, ffmpeg, tvtime, vidix...) so
changing the way you suggest would create and extra burden to whoever
merge future updates from these projects.
i have no objections to changing the macro usage for parts of code
that are xine specific though.
> It also checks for __PIC__ instead of just PIC because the first one is
> automatical when you use -fPIC instead the other one depends on libtool's
> -DPIC param.
well, you are the port maintainer expert ;-)
if you can please split this part of patch i will apply it.