From: James S. <jst...@gm...> - 2003-03-18 16:43:30
|
Hi, On Tue, 2003-03-18 at 18:27, Miguel Freitas wrote: > About the post plugins i would rather see it the other way around: > suppose i have goom->my_filter->xshm and my_filter doesn't support > RGB32. in that case my_filter would intercept the capabilities call to > make sure it will not report RGB. Agreed. > In any case, the patch looks very good to me to. if James is willing to > take the work of coding the missing scaling and conversion functions i > think it is good to have it. > > btw, i thought that goom would output a different RGB format when > compiled at big endian machines and also some other decoders (eg. win32) > may output even another format (i don't know). so be aware that you > might be just hitting the top of the iceberg! ;) Indeed, there are a lot of rgb formats to convert between. I'm happy enough to work my way through them, as they're all pretty simple. Like I said before I may need some help with scaling, I had a brief look at the scaling in yuv2rgb.c and most of it didn't really make much sense to me. Shall I commit it gradually (disabled by default) or wait until it's all finished? James. |