[xine-devel] Re: disposing video_out

[Ewald S. <ew...@ra...>]

Hi Miguel,

[...]

> >    stream->osd_renderer->close( stream->osd_renderer );
> > -  /* it makes no sense to dispose a video port on stream dispose */
> > -  /* stream->video_out->exit (stream->video_out); */
> > +  stream->video_out->exit (stream->video_out);
> >    stream->video_fifo->dispose (stream->video_fifo);
>
> i must disagree. this is wrong, and still makes no sense. segfault is
> not a valid argument because with the stream->video_out->exit() the
> subtitles (and also master/slave) support will segfault.

Sorry, I didn't think about that. :(

[...]

> otoh, you said that vo port must be disposed, which is quite reasonable.
> so i think we must implement the xine_close_video_driver and use it
> (xine-ui already does the right thing).

Okay, it works great now. Thank you for quickly providing this solution. :))

> regards,
>
> Miguel

bye,

ewald