Hmm, is your patch going to affect DVB TS streams, e.g. from a HDTV channel? Some HDTV channels broadcast 2.0 sound for one program, followed by 5.1 sound for another. Or possibly interrupt a movie with 5.1 sound to show commercials with 2.0 sound.

I'm worried that closing and reopening the audio device is going to break HDTV playback. Have you tested this scenario, please?

Cheers,
Chris


From: Torsten Jager <t.jager@gmx.de>
To: Chris Rankin <rankincj@yahoo.com>
Cc: xine-devel@lists.sourceforge.net
Sent: Wednesday, 27 March 2013, 16:26
Subject: Re: AAC 5.1 audio is broken in xine-lib-1.2

Hello,

I'm quite angry with you about reverting my patch that
quick (and breaking another patch of mine as well this way).
A simple change of faad decoder priority would have done it, too.

> Hi,
> I have a couple of movie trailer files that use AAC 5.1 audio.
> This used to be decoded by libfaad, but is now being decoded by
> FFmpeg instead

This is my intention. At least with ffmpeg 1.1.2, it does fix
most of my issues from my "hifi aac" thread.

Your file is indeed broken. It supplies invalid settings
in container head. Maybe you should improve your taste of movies ;-)

Anyway, this should fix it - if those earlier patches would be
still there...

Torsten