Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#27 [1.19.2] Use different icon for overmounted folder

closed
nobody
None
5
2009-10-19
2009-06-19
Anonymous
No

The suggested patch answers bug report #2806232, see:

http://sourceforge.net/tracker/?func=detail&aid=2806232&group_id=64835&atid=508822

Description: When mounting something on a folder that is not listed in the static device list (/etc/fstab), Xfe 1.19.2 keeps using the regular "folder" icon. There is no visual indication that the folder is now a mount point. That is impractical when manually mounting stuff. For example, when manually mounting a USB stick on /mnt ("mount /dev/sda1 /mnt"), the same "folder" icon is used for /mnt before and afterwards. -- With the attached patch, Xfe looks at both the static (/etc/fstab) and the dynamic (/etc/mtab, or more precisely: /proc/mounts) device list when deciding which icon to show. With the patch, /mnt gets a different icon after the USB stick is mounted there.

Limitations:

(1) The icon change takes place the next time Xfe updates its internal lists, which is driven by Xfe's timers and timeout values, and thus can take a short while.

(2) Xfe's source code special-cases "proc" filesystems (usually mounted on /proc). I do not know why, so the patch does not touch that.

Discussion

  • Roland Baudin
    Roland Baudin
    2009-10-19

    This should be fixed in Xfe released version 1.32.
    Thanks for the patch.
    RB

     
  • Roland Baudin
    Roland Baudin
    2009-10-19

    • status: open --> closed