#179 Xfe: Crash on file selection

v1.0_(example)
closed-fixed
nobody
None
5
2013-08-24
2013-03-09
beastie
No

To reproduce the bug, open a directory with few files. In the white area in the right panel, press and hold the mouse left button. Move the mouse up. Xfe crashes as soon as I reach the last file/directory in the list (or the ".." parent directory in an empty directory).

If I do the above really fast, it may not crash. But usually it does.

Also, when it doesn't crash when moving the mouse up rapidly, if I keep button held and move the mouse back down it crashes again as soon as it reaches the lowest file/directory in the list.

This bug was not present in version 1.33.

This is on FreeBSD 9.1. Can you confirm the regression?

Thank you.

Discussion

  • Mike Edwards
    Mike Edwards
    2013-03-15

    I can confirm this.

    This only happens if no file in the right hand panel is selected at all (either highlighted blue or with a dotted outline)

    To reproduce:

    1. Select any directory (with just a few files in, so there's some blank space at the bottom of the panel) from the left panel. Don't click on any files in the right hand panel, so there should be no selection at all.
    2. Click in the blank space underneath the files and drag upwards to select them. As soon as you hit the bottom file it crashes.

    It doesn't crash if before step 2 you right click on any file in the right panel to give it a dotted outline.

    This call to current->list->isItemFile in FilePanel.cpp causes the crash:

    // If there is a selected file, disable the paste button and return
    int numsel=current->list->getNumSelectedItems();
    if (numsel == 1 && current->list->isItemFile(current->list->getCurrentItem()))
    {
    o->handle(this,FXSEL(SEL_COMMAND,FXWindow::ID_DISABLE),NULL);
    return 1;
    }

    As far as I can tell getCurrentItem() returns -1 because, although you've started highlighting files, there isn't actually a "current item" as no file has a dotted outline.

     
  • Roland Baudin
    Roland Baudin
    2013-08-24

    • status: open --> closed-fixed
    • Group: --> v1.0_(example)
     
  • Roland Baudin
    Roland Baudin
    2013-08-24

    This is fixed in Xfe 1.35.
    Thanks for the bug report.
    RB