Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#97 jonas tags for the xdoclet samples

closed-fixed
Andy Stevens
xdoclet (14)
5
2002-09-26
2002-09-12
Mathieu Peltier
No

Hi,

Please find enclosed the modified XDoclet samples with
jonas-specific tags for the JOnAS application server,
as Andrew Stevens asked me (see here:
https://sourceforge.net/tracker/index.php?func=detail&aid=594029&group_id=31602&atid=402706\)
I have replied on the xdoclet-dev mailing list, but I
think that to submit a new patch is better?)

The cvs diff file contains also minor updates for the
jonas (objectweb) module:

JonasSubTask.java:
* rename default jonas dd file name variable from
JONAS_DD_FILE_NAME into DEFAULT_JONAS_DD_FILE_NAME
* add a DEFAULT_VERSION variable in the JonasVersionTypes
* modified '@param version' description to tell user
what are the supported versions

jonas.xdt
* fixed typo (in particular the ident step in order
to try to make the file more readable)

xtags.xml
* warned the user that the tags 'shared',
'max-cache-size', 'min-pool-size' have only been
present since version 2.4, and that 'jndi-name'
concerns only the Entity and Session beans, is
mandatory if version < 2.5, but optional for Session
beans for 2.5 onwards.

Remark: I think that to rename the module from
'objectweb' to 'jonas' could be also better?

Thanks
Best regard

Discussion

  • cvs diff file based on the current cvs state

     
    Attachments
  • Andy Stevens
    Andy Stevens
    2002-09-13

    Logged In: YES
    user_id=247081

    >Remark: I think that to rename the module from
    >'objectweb' to 'jonas' could be also better?

    The standard we decided on when the module refactoring was
    done was to use the vendor as the module name, and product
    as a sub-package of that. In Jonas' case, this is Objectweb.

    Having said that, there has been some talk of splitting
    modules down further (e.g. to separate the apache SOAP and
    apache Struts stuff, since they're not really related and so
    might be better as two modules), so this may change again
    in the future. I don't think it'll be before 1.2, though, since
    that's pretty close now.

     
  • Andy Stevens
    Andy Stevens
    2002-09-13

    • assigned_to: nobody --> stevensa
     
  • Andy Stevens
    Andy Stevens
    2002-09-19

    Logged In: YES
    user_id=247081

    Now applied to CVS (mostly). I haven't done the jonas.xdt
    one, because
    - it won't apply automatically (I just get a message saying
    it's "not applicable", which usually means the "old" lines in
    the patch don't match what it's finding at those line
    numbers in the file.
    - a bunch of the "new" lines have tabs instead of spaces, so
    it doesn't line up any better for me (using tab size = 3) So
    I don't really fancy going through and applying it all
    manually if it's just cosmetic changes which don't even look
    right for me anyway...

     
  • Logged In: YES
    user_id=593556

    > Now applied to CVS (mostly).
    Ok thank you.

    > - it won't apply automatically (I just get a message saying
    > it's "not applicable", which usually means the "old" lines in
    > the patch don't match what it's finding at those line
    > numbers in the file.
    > - a bunch of the "new" lines have tabs instead of spaces, so
    > it doesn't line up any better for me (using tab size = 3) So
    > I don't really fancy going through and applying it all
    > manually if it's just cosmetic changes which don't even look
    > right for me anyway...
    ok no problem. It is not important.

    > >Remark: I think that to rename the module from
    > >'objectweb' to 'jonas' could be also better?
    >
    > The standard we decided on when the module refactoring was
    > done was to use the vendor as the module name, and product
    > as a sub-package of that. In Jonas' case, this is Objectweb.

    Ok I do not know that.

    Thanks,
    Best regards,

     
  • Andy Stevens
    Andy Stevens
    2002-09-26

    • status: open --> closed-fixed